Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): aligned font of the events page #311

Merged
merged 11 commits into from
Aug 10, 2023
Merged

feat(frontend): aligned font of the events page #311

merged 11 commits into from
Aug 10, 2023

Conversation

Illaf
Copy link
Contributor

@Illaf Illaf commented Jul 2, 2023

Fixes Issue #306

Changes proposed

The font in the events page was different from the rest of the website .Hence I have removed font weight in the page so that uniformity and theme is maintained in the entire website.
Screenshot (28)

Screenshots

Note to reviewers

@vercel
Copy link

vercel bot commented Jul 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devs-in-tech ❌ Failed (Inspect) Jul 19, 2023 7:29am

@netlify
Copy link

netlify bot commented Jul 2, 2023 •
edited
Loading

❌ Deploy Preview for devsintech failed.

Name Link
🔨 Latest commit 1237ead
🔍 Latest deploy log https://app.netlify.com/sites/devsintech/deploys/64d4fb586f320d000805a40e

prnvtripathi
prnvtripathi suggested changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@prnvtripathi prnvtripathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove font-bold from the content only and not from the headings.

@Illaf
Copy link
Contributor Author

Illaf commented Jul 2, 2023

@prnvtripathi Ok

@Illaf
Copy link
Contributor Author

Illaf commented Jul 2, 2023

@prnvtripathi done!

@Susmita-Dey Susmita-Dey linked an issue Jul 3, 2023 that may be closed by this pull request
[Feature] <changing the font of events page> #306
Closed
Susmita-Dey
Susmita-Dey requested changes Jul 3, 2023
View reviewed changes
Copy link
Member

@Susmita-Dey Susmita-Dey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Align this text to the left and not centered and remove font-bold from here
Also, update your branch

@Susmita-Dey Susmita-Dey added enhancement New feature or request gssoc23 This label is assigned to those who want to work on an issue under GSSoC23 level2 25 Points (Enhancement of Exisiting feature) labels Jul 3, 2023
@Illaf
Copy link
Contributor Author

Illaf commented Jul 3, 2023

@Susmita-Dey okay

@Illaf
Copy link
Contributor Author

Illaf commented Jul 3, 2023

image

Align this text to the left and not centered and remove font-bold from here Also, update your branch

@Susmita-Dey Done!👍

Susmita-Dey
Susmita-Dey approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@Susmita-Dey Susmita-Dey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Susmita-Dey Susmita-Dey mentioned this pull request Jul 3, 2023
Closed
@Susmita-Dey Susmita-Dey requested review from prnvtripathi and removed request for prnvtripathi July 4, 2023 03:24
@Susmita-Dey
Copy link
Member

@prnvtripathi Can you kindly review this PR?

We have to merge it

@Illaf
Copy link
Contributor Author

Illaf commented Jul 6, 2023

@Susmita-Dey Please merge this pull request

@Susmita-Dey
Copy link
Member

@devs-in-tech/devsintech-web-team Someone review and merge this pull request

prnvtripathi
prnvtripathi approved these changes Jul 9, 2023
View reviewed changes
Copy link
Contributor

@prnvtripathi prnvtripathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge :)

prnvtripathi
prnvtripathi approved these changes Jul 9, 2023
View reviewed changes
Copy link
Contributor

@prnvtripathi prnvtripathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved some merge conflicts.

@vercel
Copy link

vercel bot commented Jul 19, 2023

@Susmita-Dey is attempting to deploy a commit to the DevsInTech Team on Vercel.

A member of the Team first needs to authorize it.

@Susmita-Dey Susmita-Dey merged commit 2c033bf into devs-in-tech:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prnvtripathi prnvtripathi prnvtripathi approved these changes

@Susmita-Dey Susmita-Dey Susmita-Dey approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request gssoc23 This label is assigned to those who want to work on an issue under GSSoC23 level2 25 Points (Enhancement of Exisiting feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] <changing the font of events page>
3 participants
@Illaf @Susmita-Dey @prnvtripathi