create book #5
Open
create book #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,4 @@ | |||
| <% flash.each do |message_type, message| %> | |||
| <%= content_tag(:div, message, class: "alert alert-#{message_type}") %> | |||
| <% end %> | |||
There was a problem hiding this comment.
Parece que las lineas 1 a 3 son las mismas que en app/views/recipes/show.html.erb
¿Se te ocurre como podríamos mejorarlo @Vollcode ?
There was a problem hiding this comment.
Podríamos hacer un extract method de ello, que te parece @Pardiez ?
There was a problem hiding this comment.
me parece que para extraer un "método" habría que tener uno 😉
pero la idea es la misma: evitar esa repetición
De hecho me sé de un tutorial de Rails que te enseña a hacer una aplicación tipo twitter que tiene un ejemplo idéntico, con esas mismas lineas de código 😉 😉
|
Tened en cuenta que el objetivo de las PR no es corregir o aleccionar ad hominem, sino identificar los puntos a resolver en equipo, proponiendo soluciones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created book according to the Recipe model