Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: treat pipeline flag defaults consistently when used as command f… #2798

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

lizardruss
Copy link
Collaborator

…lags or pipeline flags

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves ENG-2735

Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace would treat pipeline flag default values differently when used as command flags vs pipeline flags.

Copy link

netlify bot commented Jan 30, 2024

Deploy Preview for devspace-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 99ad69b
🔍 Latest deploy log https://app.netlify.com/sites/devspace-docs/deploys/65cff09a59a9ab0008a8705b
😎 Deploy Preview https://deploy-preview-2798--devspace-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lizardruss lizardruss marked this pull request as draft January 31, 2024 18:42
…lags or pipeline flags

Signed-off-by: Russell Centanni <[email protected]>
@lizardruss lizardruss marked this pull request as ready for review February 16, 2024 23:31
ENG-2735

Signed-off-by: Russell Centanni <[email protected]>
Copy link
Contributor

@89luca89 89luca89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lizardruss lizardruss merged commit b6dd518 into devspace-sh:main Feb 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants