fix: app details calc cleanup #2529
Open
+824
−928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feat/app-details-calc-cleanup
Elessar1802
requested review from
vivek-devtron and
vikramdevtron
as code owners
eshankvaish
requested changes
Mar 7, 2025
| </ConditionalWrap> | ||
| ) | ||
|
|
||
| if (jsonManifestData?.kind !== 'Secret' || isEditMode || secretViewAccess) { |
There was a problem hiding this comment.
Suggested change
| if (jsonManifestData?.kind !== 'Secret' || isEditMode || secretViewAccess) { | |
| if (jsonManifestData?.kind !== 'Secret' || isEditMode || !secretViewAccess) { |
| }, | ||
| ) | ||
| }) | ||
| .catch(noop) |
There was a problem hiding this comment.
While it's great to have catch but can you verify if the error was supposed to be propagated here? Same applied to other places as well
| @@ -562,11 +648,11 @@ export const Details: React.FC<DetailsType> = ({ | |||
| clearPollingInterval() | |||
| if (isPollingRequired) { | |||
| appDetailsIntervalID = setInterval(callAppDetailsAPI, interval) | |||
| callAppDetailsAPI(true) | |||
| callAppDetailsAPI(true).then(noop).catch(noop) | |||
|
| const callAppDetailsAPI = async (fetchExternalLinks?: boolean) => { | ||
| appDetailsAPI(params.appId, params.envId, interval - 5000, appDetailsAbortRef) | ||
| .then(async (response) => { | ||
| // eslint-disable-next-line no-param-reassign |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: