Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimise dockerfile #6226

Open
wants to merge 81 commits into
base: main
Choose a base branch
from

Merge branch 'develop' into dockerfile-optimise

2974559
Select commit
Loading
Failed to load commit list.
Open

optimise dockerfile #6226

Merge branch 'develop' into dockerfile-optimise
2974559
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks completed Jan 16, 2025 in 44s

3 secrets uncovered!

3 secrets were uncovered from the scan of 81 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #6293: dockerfile-optimise 👉 develop (6 commits)

  • Pull request #6226: dockerfile-optimise 👉 main (75 commits)

GitGuardian id GitGuardian status Secret Commit Impacted PRs Filename
14998970 Triggered Generic Password de8652b #6226 client/argocdServer/repoCredsK8sClient/repositoryCredsManager.go View secret
10220829 Triggered Generic High Entropy Secret 2974559 #6293 charts/devtron/values.yaml View secret
463396 Triggered Generic Password 9672e0f #6226 pkg/chartRepo/ChartRepositoryService.go View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.