-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Images to Bars in Race #25
base: master
Are you sure you want to change the base?
Conversation
… some docstrings.
Well done, do you intend to update the tutorial.md file and describe how to add the images to the bars? |
I totally forgot about that document. I will include a description of how to use the new parameters. There is still a lot of work to do to get it working for all cases. |
I created a YouTube video about a bar chart race I made using this package and the modification. The end of the video is mainly showing the code, in case someone wants to collaborate and wants to see what I did (more specific code part is around minute 5 or 6, but look at the timestamps): |
Embedded link go to local host!? |
Sorry, I messed up the order of the hyperlink in mark down in the first try, but it is fixed now. |
These are some of the changes I included to be able to add images to the bars as they move (check gif in README.md file).
I am creating a pull request so that other people can take a look.
Right now it is not very generalizable and things could move much faster with someone who actually knows how Matplotlib works.
The only changes with respect to the original project are in _bar_chart_race.py and in the README.md file to explain my goal. I included 3 additional parameters to the initializer class plus a docstring at the end.