Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filled maps (non-persistent, not rendered from terrain) #478

Draft
wants to merge 60 commits into
base: master
Choose a base branch
from

Conversation

Endermanbugzjfc
Copy link
Contributor

@Endermanbugzjfc Endermanbugzjfc commented Apr 23, 2022

Items

  • Filled map variants

Packets

  • Map info request handler
  • Broadcast pixel changes with offset
  • Broadcast decoration changes

APIs

  • API to register create map data
  • API to update map data

@Endermanbugzjfc Endermanbugzjfc marked this pull request as draft April 23, 2022 09:17
@Endermanbugzjfc
Copy link
Contributor Author

Compiler exit with code 2??

This reverts commit 7f40354.
@Endermanbugzjfc
Copy link
Contributor Author

@JustTalDevelops JustTalDevelops added the feature New feature or request label Jul 14, 2022
@Endermanbugzjfc
Copy link
Contributor Author

Endermanbugzjfc commented Jul 21, 2022

I am not sure how I should indicate a map as persisted. Using map ID 0? Map ID is an int64. It is not as easy as adding another field. Since this requires saving another unnecessary and non-official NBT tag in disk.

@Endermanbugzjfc
Copy link
Contributor Author

Endermanbugzjfc commented Jul 21, 2022

Rename MapDataViewer to MapViewer?

@Endermanbugzjfc
Copy link
Contributor Author

I am not sure how I should indicate a map as persisted. Using map ID 0? Map ID is an int64. It is not as easy as adding another field. Since this requires saving another unnecessary and non-official NBT tag in disk.

I am going to use the map_is_init NBT field for this. Map data provider will only give access to player whose map has true for that field.

@Endermanbugzjfc
Copy link
Contributor Author

I am not sure how I should indicate a map as persisted. Using map ID 0? Map ID is an int64. It is not as easy as adding another field. Since this requires saving another unnecessary and non-official NBT tag in disk.

I am going to use the map_is_init NBT field for this. Map data provider will only give access to player whose map has true for that field.

I decide to not mess with persistence in this PR.

@Endermanbugzjfc
Copy link
Contributor Author

Locked map item should be added. But I can not find the item ID on Fandom.

@Endermanbugzjfc Endermanbugzjfc changed the title Filled map and API Maps (runtime) Jul 26, 2022
@Endermanbugzjfc Endermanbugzjfc changed the title Maps (runtime) Maps (non-persistent) Jul 26, 2022
@Endermanbugzjfc Endermanbugzjfc changed the title Maps (non-persistent) Filled maps (non-persistent, not rendered from terrain) Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants