Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a fall manager for entities #549

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Added a fall manager for entities #549

wants to merge 15 commits into from

Conversation

HashimTheArab
Copy link
Contributor

No description provided.

Sandertv
Sandertv reviewed Jul 10, 2022
View reviewed changes
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Please make sure to fix the issues pointed out by the CI. Also, for future reference, please do add a description for your PR so we can get an idea of the reason for your PR and the changes you've made.

@HashimTheArab
Copy link
Contributor Author

anything else on this?

@JustTalDevelops JustTalDevelops added the improvement Improvement of an existing part of the codebase label Jul 14, 2022
@JustTalDevelops JustTalDevelops changed the title Fall manager Added a fall manager for entities Jul 14, 2022
T14Raptor
T14Raptor reviewed Jul 14, 2022
View reviewed changes
server/entity/fall.go Outdated Show resolved Hide resolved
@JustTalDevelops
Copy link
Member

Would also remove the fall distance calculation code in falling block and make it adopt this system.

@HashimTheArab
Copy link
Contributor Author

Would also remove the fall distance calculation code in falling block and make it adopt this system.

is the latest commit fine?

@Sandertv
Copy link
Member

There is a bit of an awkward "cycle" between this fall manager and the movement computer. Maybe it'd be an idea to merge them?

@HashimTheArab
Copy link
Contributor Author

There is a bit of an awkward "cycle" between this fall manager and the movement computer. Maybe it'd be an idea to merge them?

Could you elaborate more on that

@Sandertv Sandertv added this to the v0.11.0 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T14Raptor T14Raptor T14Raptor left review comments

@JustTalDevelops JustTalDevelops JustTalDevelops left review comments

@Sandertv Sandertv Sandertv left review comments

Assignees
No one assigned
Labels
improvement Improvement of an existing part of the codebase
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@HashimTheArab @JustTalDevelops @Sandertv @T14Raptor