-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduces new package @dfinity/core #681
base: main
Are you sure you want to change the base?
Conversation
size-limit report 📦
|
Not sure So yeah, I'm hesitant. If we do so we should probably move it over to https://github.com/dfinity/agent-js repo (not against) and split one of two things that are not utils per sé. |
I agree with @peterpeterparker, I'm not sure that utils should be part of the core. It's very specific to NNS, except for the helpers Not a strong opinion either, but I also agree on moving it here if we do so. |
My view is that there should be a base set of utils, that even
I also would support moving the buffer and leb utility methods out of |
@krpeacock @peterpeterparker I came across this again. Should we continue with this? Did something change? |
@lmuntaner After doing some exploration of other packages, I decided that it would be a better approach to fold all of the packages into The refactor was more than I could pull off in a cooldown week (I did try), so I'd need to prioritize it as a feature if I wanted to get this through |
@krpeacock that makes sense. Does Those seem from a different domain than agent. Maybe inside |
Description
Since it was becoming a pain to install the individual packages, since most of them were already necessary for the auth-client anyway, this PR introduces
@dfinity/core
, a bundle ofSo you can rapidly get to work building instead of maintaining versions. The individual packages will still be maintained and released separately for projects that have specific needs and want to reduce bloat.
Checklist: