Holistic Discourse / forum post link handling. #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* There are several modalities now: omit, ask, supply an URL, or use Discourse. * Arguments for Discourse and forum post handling move to each individual command. * When the Discourse behavior fails to create a post, it will ask for the user, *and* it will update the post afterwards. * Motion proposals have gained a formulaic forum post autocomposed based on the title and text of the proposal. * Formerly, new posts would be hidden by the update Discourse forum post call. Now, only posts submitted in reply to a topic are hidden after update. To-do: * When using the modality Discourse, if a proposal failed, then delete the corresponding forum post.
DFINITYManu
force-pushed
the
discoursefuncs
branch
from
ed72f2d to
287988a
Compare
DFINITYManu
force-pushed
the
discoursefuncs
branch
from
be5375a to
33b032b
Compare
… proposals. Rationale: the forum post link is already in the proposal. Requiring a forum post to compose the proposal summary creates a chicken-and-egg problem whereby the proposal requires the forum post and the forum post requires the proposal. Hacks in the codebase to get around that problem include, but are not limited to, generating the summary twice (once for test run and once for final run). Removal of this makes the codebase cleaner and makes it harder to make a programming mistake that would result in no forum post, or the wrong forum post link, or a forum post without a proposal being submitted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To-do:
ic_admin.propose_*), but not all.