Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TT-409): bubble up protocol errors to the client #25

Merged
merged 3 commits into from
Oct 22, 2024
Merged

fix(TT-409): bubble up protocol errors to the client #25

merged 3 commits into from
Oct 22, 2024

Conversation

raymondk
Copy link
Contributor

  • Bump the version of ic-agent to 0.38.2 so that it stops retrying 429s indefinitely and bubbles up 429s
  • Make the http gateway forward 429s from the node
  • Add a test with a mock container

@raymondk raymondk requested a review from a team as a code owner October 17, 2024 00:53
@raymondk raymondk requested a review from nathanosdev October 17, 2024 00:53
@raymondk raymondk requested a review from r-birkner October 21, 2024 13:37
nathanosdev
nathanosdev reviewed Oct 21, 2024
View reviewed changes
Cargo.toml Show resolved Hide resolved
packages/ic-http-gateway/tests/protocol_error_tests.rs Outdated Show resolved Hide resolved
packages/ic-http-gateway/tests/protocol_error_tests.rs Outdated Show resolved Hide resolved
packages/ic-http-gateway/tests/protocol_error_tests.rs Outdated Show resolved Hide resolved
@nathanosdev nathanosdev merged commit 25722e8 into main Oct 22, 2024
3 checks passed
@nathanosdev nathanosdev deleted the raymond/TT-409 branch October 28, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanosdev nathanosdev nathanosdev approved these changes

@r-birkner r-birkner Awaiting requested review from r-birkner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raymondk @nathanosdev