Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove dependency on regex to reduce WASM size #29

Merged
merged 2 commits into from
Nov 12, 2024
Merged

fix: remove dependency on regex to reduce WASM size #29

merged 2 commits into from
Nov 12, 2024

Conversation

przydatek
Copy link
Contributor

@przydatek przydatek commented Nov 5, 2024 •
edited
Loading

Using regex-crate increases the WASM-size of canisters by over 100 kB. This PR replaces regex with a custom function for "manual" parsing of Content-Range-header. For example the canister http_gateway_canister_custom_assets with regex had size 466'631 bytes, while with the custom function only 344'593 bytes.

TT-440

@przydatek przydatek requested a review from nathanosdev November 5, 2024 17:22
@przydatek przydatek marked this pull request as ready for review November 5, 2024 17:22
@przydatek przydatek requested a review from a team as a code owner November 5, 2024 17:22
@przydatek przydatek merged commit 1de90ba into main Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanosdev nathanosdev nathanosdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@przydatek @nathanosdev