-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Access Control Enhancements #644
Draft
amber-vale
wants to merge
15
commits into
dfir-iris:develop
Choose a base branch
from
amber-vale:access-control-enhancements
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] Access Control Enhancements #644
amber-vale
wants to merge
15
commits into
dfir-iris:develop
from
amber-vale:access-control-enhancements
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error handling has been migrated to the root API V2 blueprint, that will handle them automatically. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisiting my previous #518 PR and getting up to date with the latest of IRIS changes, continuing to work on the access control enhancements. This is heavily work in progress still. Feedback and input welcome. :)
I am going to overhaul the current access control, breaking down access to be per-action, per-resource kind and per-resource ID. Defining resources will be done in
source/app/blueprints/authorization/resources.toml
. I plan to support assignment to users, groups, and by case, similar to the current permissions setup. I am going to start implementing these changes with the V2 API and then slowly work backwards to the older and older routes.Resources will have their primary
kind
with any additional classifiers added as dot-notated to the end of the name, such as[case.some_sub_classification]
to restrict the scope.Currently supported actions are:
Permissions will be interacted with in code as an object, stored in the database as a delimited string.
To Do List
resources.toml
fileresources.toml
for validation & intellisenseresources.toml
@Authorization.required(resource, action)
for checking accessUnauthorized
exceptionOther Enhancements
Unauthorized
andBusinessProcessingError
. Additional handlers will be created for other exceptions as I continue to learn the codebase better.