Api v2 delete note #734
Merged
Api v2 delete note #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r}/notes, to create a note
… case_identifier does not exist
… with directory_id does not exist
… with directory_id is in another case
…identifier}/notes
…/{case_identifier}/notes/{identifier}
…not correspond to existing objects
… to any existing case
…cases/{case_identifier}/notes/{identifier}
…v2/cases/{case_identifier}/notes/{identifier}
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
8 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -130,5 +124,4 @@ | |||
| track_activity(f'user \'{user.user}\' successfully logged-in', ctx_less=True, display_in_ui=False) | |||
|
|
|||
| next_url = _filter_next_url(request.args.get('next'), user.ctx_case) | |||
|
|
|||
| return redirect(next_url) | |||
| return redirect(next_url) | |||
Check warning
Code scanning / CodeQL
URL redirection from remote source Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 4 days ago
To fix the problem, we need to enhance the URL validation to ensure that the next_url is safe for redirection. We will:
- Update the
_is_safe_urlfunction to handle additional edge cases, such as URLs with backslashes and malformed URLs. - Ensure that the
next_urlis either a relative URL or has the same host as the current request. - Use the
url_has_allowed_host_and_schemefunction from Django (if available) or implement similar logic to validate the URL.
Suggested changeset
1
source/app/business/auth.py
| @@ -76,5 +76,5 @@ | ||
| """ | ||
| ref_url = urlparse(request.host_url) | ||
| target = target.replace('\\', '') | ||
| test_url = urlparse(urljoin(request.host_url, target)) | ||
| return test_url.scheme in ('http', 'https') and ref_url.netloc == test_url.netloc | ||
| return test_url.scheme in ('http', 'https') and not test_url.netloc or test_url.netloc == urlparse(request.host_url).netloc | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of endpoint
DELETE /api/v2/cases/{case_identifier}/notes/{identifier}to delete a note.Tasks performed:
POST /case/notes/delete/{note_id}PUT /api/v2/cases/{case_identifier}/notes/{identifier}should return 403 when user has no permission to access to caseThis PR goes with the accompanying documentation iris-doc-src PR#44.
It is built on top of branch
api_v2_update_node. So it should not be merged before PR#732