Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Ignore check localhost to whitelist on Bitcoin Core #479

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

twofaktor
Copy link

Local connections (localhost) do not need to be explicitly whitelisted, as connections from 127.0.0.1 are always allowed without restriction by the Bitcoin node.

This PR fixes the code to avoid the localhost is not whitelisted notice on your node

@twofaktor twofaktor changed the title [BUG] Ignore check localhost to whitelist on Bitcoin Core [FIX] Ignore check localhost to whitelist on Bitcoin Core Sep 24, 2024
@NicolasDorier
Copy link
Member

NicolasDorier commented Oct 29, 2024

hey @twofaktor sorry for the slow feedback. I couldn't find what you are saying in bitcoin core's source. Are you sure?
Whitelisting is different concept than just allowing a connection. While 127.0.0.1 is accessible, it doesn't mean that the p2p has proper permissions which wouldn't warrant such warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants