Merge branch 'paulswartz/openssl-md5/erlangGH-7987/OTP-18931' into maint

* paulswartz/openssl-md5/erlangGH-7987/OTP-18931: ci: don't use cache if an `.h` file is deleted fix: `ifdef` for preprocessor variables fix: rename `openssl/md5.h` to avoid include conflicts with OpenSSL
dgud · Jan 15, 2024 · a66154d · a66154d
2 parents 9f3dfc5 + d27de65
commit a66154d
Show file tree

Hide file tree

Showing 13 changed files with 13 additions and 12 deletions.
diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
@@ -96,6 +96,7 @@ jobs:
           filters: |
               no-cache:
                   - '.github/**'
+                  - deleted: '**/*.h'
               deleted:
                   - deleted: '**'
               bootstrap:

diff --git a/erts/emulator/openssl/README b/erts/emulator/openssl/README
@@ -7,7 +7,7 @@ The files that has been taken from the 3.1.4 version of OpenSSL:
 ./crypto/md5/md5_local.h
 ./crypto/md5/md5_dgst.c
 ./include/crypto/md32_common.h
-./include/openssl/md5.h
+./include/openssl_local/md5.h (renamed from include/openssl/md5.h)
 
 The openssl.diff file contains the diff between the original files and the ones
 included in OTP.

diff --git a/erts/emulator/openssl/crypto/md5/md5_local.h b/erts/emulator/openssl/crypto/md5/md5_local.h
@@ -10,7 +10,7 @@
 #include <stdlib.h>
 #include <string.h>
 #if defined(ERLANG_OPENSSL_INTEGRATION)
-#include "openssl/md5.h"
+#include "openssl_local/md5.h"
 #define md5_block_data_order MD5_BLOCK_DATA_ORDER_FUNCTION_NAME
 #undef MD5_ASM
 #else

diff --git a/erts/emulator/openssl/include/erl_md5.h b/erts/emulator/openssl/include/erl_md5.h
@@ -30,6 +30,6 @@
 #define MD5_TRANSFORM_FUNCTION_NAME             MD5Transform
 #define MD5_BLOCK_DATA_ORDER_FUNCTION_NAME      MD5BlockDataOrder
 
-#include "openssl/md5.h"
+#include "openssl_local/md5.h"
 
 #endif
diff --git a/erts/emulator/openssl/include/openssl/md5.h → ...lator/openssl/include/openssl_local/md5.h b/erts/emulator/openssl/include/openssl/md5.h → ...lator/openssl/include/openssl_local/md5.h
diff --git a/erts/emulator/openssl/openssl.diff b/erts/emulator/openssl/openssl.diff
@@ -46,7 +46,7 @@ diff -u original/crypto/md5/md5_local.h crypto/md5/md5_local.h
  #include <stdlib.h>
  #include <string.h>
 +#if defined(ERLANG_OPENSSL_INTEGRATION)
-+#include "openssl/md5.h"
++#include "openssl_local/md5.h"
 +#define md5_block_data_order MD5_BLOCK_DATA_ORDER_FUNCTION_NAME
 +#undef MD5_ASM
 +#else
@@ -116,7 +116,7 @@ diff -u original/include/crypto/md32_common.h include/crypto/md32_common.h
  # error "HASH_MAKE_STRING must be defined!"
 diff -u original/include/openssl/md5.h include/openssl/md5.h
 --- original/include/openssl/md5.h	2023-11-24 15:58:28.610171865 +0100
-+++ include/openssl/md5.h	2023-11-24 23:10:52.570854593 +0100
++++ include/openssl_local/md5.h	2023-11-24 23:10:52.570854593 +0100
 @@ -11,6 +11,15 @@
  # define OPENSSL_MD5_H
  # pragma once

diff --git a/erts/emulator/openssl/openssl.mk b/erts/emulator/openssl/openssl.mk
@@ -50,4 +50,4 @@ $(OPENSSL_OBJDIR)/%.o: $(OPENSSL_DIR)/crypto/md5/%.c
 $(OPENSSL_OBJDIR)/md5_dgst.o: $(OPENSSL_DIR)/crypto/md5/md5_dgst.c \
 	$(OPENSSL_DIR)/crypto/md5/md5_local.h \
 	$(OPENSSL_DIR)/include/crypto/md32_common.h \
-	$(OPENSSL_DIR)/include/openssl/md5.h
+	$(OPENSSL_DIR)/include/openssl_local/md5.h
diff --git a/erts/lib_src/common/erl_misc_utils.c b/erts/lib_src/common/erl_misc_utils.c
@@ -42,7 +42,7 @@
 #    include <sys/select.h>
 #  endif
 #  include <time.h>
-#  if HAVE_SYS_TIME_H
+#  ifdef HAVE_SYS_TIME_H
 #    include <sys/time.h>
 #  endif
 #  include <string.h>

diff --git a/lib/erl_interface/src/openssl/README b/lib/erl_interface/src/openssl/README
@@ -7,7 +7,7 @@ The files that has been taken from the 3.1.4 version of OpenSSL:
 ./crypto/md5/md5_local.h
 ./crypto/md5/md5_dgst.c
 ./include/crypto/md32_common.h
-./include/openssl/md5.h
+./include/openssl_local/md5.h (renamed from include/openssl/md5.h)
 
 The openssl.diff file contains the diff between the original files and the ones
 included in OTP.

diff --git a/lib/erl_interface/src/openssl/crypto/md5/md5_local.h b/lib/erl_interface/src/openssl/crypto/md5/md5_local.h
@@ -10,7 +10,7 @@
 #include <stdlib.h>
 #include <string.h>
 #if defined(ERLANG_OPENSSL_INTEGRATION)
-#include "openssl/md5.h"
+#include "openssl_local/md5.h"
 #define md5_block_data_order MD5_BLOCK_DATA_ORDER_FUNCTION_NAME
 #undef MD5_ASM
 #else

diff --git a/lib/erl_interface/src/openssl/include/erl_md5.h b/lib/erl_interface/src/openssl/include/erl_md5.h
@@ -30,6 +30,6 @@
 #define MD5_TRANSFORM_FUNCTION_NAME             ei_MD5Transform
 #define MD5_BLOCK_DATA_ORDER_FUNCTION_NAME      ei_MD5BlockDataOrder
 
-#include "openssl/md5.h"
+#include "openssl_local/md5.h"
 
 #endif
diff --git a/...terface/src/openssl/include/openssl/md5.h → ...e/src/openssl/include/openssl_local/md5.h b/...terface/src/openssl/include/openssl/md5.h → ...e/src/openssl/include/openssl_local/md5.h
diff --git a/lib/erl_interface/src/openssl/openssl.diff b/lib/erl_interface/src/openssl/openssl.diff
@@ -46,7 +46,7 @@ diff -u original/crypto/md5/md5_local.h crypto/md5/md5_local.h
  #include <stdlib.h>
  #include <string.h>
 +#if defined(ERLANG_OPENSSL_INTEGRATION)
-+#include "openssl/md5.h"
++#include "openssl_local/md5.h"
 +#define md5_block_data_order MD5_BLOCK_DATA_ORDER_FUNCTION_NAME
 +#undef MD5_ASM
 +#else
@@ -116,7 +116,7 @@ diff -u original/include/crypto/md32_common.h include/crypto/md32_common.h
  # error "HASH_MAKE_STRING must be defined!"
 diff -u original/include/openssl/md5.h include/openssl/md5.h
 --- original/include/openssl/md5.h	2023-11-24 15:58:28.610171865 +0100
-+++ include/openssl/md5.h	2023-11-24 23:10:52.570854593 +0100
++++ include/openssl_local/md5.h	2023-11-24 23:10:52.570854593 +0100
 @@ -11,6 +11,15 @@
  # define OPENSSL_MD5_H
  # pragma once