Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make Navbar Sticky #419

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Fix: Make Navbar Sticky #419

merged 2 commits into from
Jan 10, 2025

Conversation

Itz-Sidra
Copy link
Contributor

Related Issue

Issue No.: #378

Description

This pull request fixes the issue of the navbar scrolling with page content, which makes it tricky for users to access navigation links quickly. To solve this, I have used the solution position: fixed on the navbar so that the navbar remains at the top of the page, no matter how much scrolling the user does. This enhances the user experience by keeping the navigation menu easily accessible at all times.

Type of PR

  • Bug fix
  • [X ] Feature enhancement
  • Documentation update
  • Security enhancement
  • Other (specify): _______________

Checklist

  • [ X] I have performed a self-review of my code.
  • [ X] I have read and followed the Contribution Guidelines.
  • [ X] I have tested the changes thoroughly before submitting this pull request.
  • [ X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [ X] I have commented my code, particularly in hard-to-understand areas.
  • [X ] I have followed the code style guidelines of this project.
  • [ X] I have checked for any existing open issues that my pull request may address.
  • [ X] I have ensured that my changes do not break any existing functionality.
  • [ X] Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.
  • [X ] I have read the resources for guidance listed below.
  • [ X] I have followed security best practices in my code changes.

Additional Context

The navbar now remains fixed at the top of the page when scrolling, improving usability. The implementation uses position: fixed instead of position: sticky for more consistent behavior across browsers.

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
100-days-100-web-project ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 5:30pm

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@dhairyagothi dhairyagothi added enhancement New feature or request BEGINNER SWOC labels Jan 10, 2025
@dhairyagothi dhairyagothi merged commit 216012c into dhairyagothi:Main Jan 10, 2025
3 checks passed
Copy link
Contributor

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants