-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to NumPy 2.0 #319
Upgrade to NumPy 2.0 #319
Conversation
e790da0
to
270b22c
Compare
270b22c
to
88fe334
Compare
Note that https://github.com/cython/cython/blob/3.0.10/Cython/Includes/numpy/__init__.pxd still exists in latest Cython ( But with NumPy 2.0, there is a problem with:
In particular:
|
This is the problematic piece of code.
__Pyx_INCREF(((PyObject*)__pyx_v_d->subarray->shape)); | ||
__pyx_r = ((PyObject*)__pyx_v_d->subarray->shape); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the problematic block; ->subarray
is being invoked on a PyArray_Descr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #320 + cython/cython#6249 (comment), the resolution was straightforward!
I may walk back some of these, need to read more about the __repr__ change.
Instead just control the `repr()` in the doctest code.
No description provided.