-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wheels.yaml
for recent CI arch changes + Python 3.12
#329
Changes from all commits
1eb7808
659c1ef
8de427f
1e15d62
317fed7
817d433
cc4e177
2fa7b3c
9a85c0a
d4555c7
e193d46
e7664a6
b9586be
c0e1259
a860f23
121afdf
7797ea6
9e26ec9
f428f29
4f780e5
2bbf246
a11429d
b53debf
cba8064
0e22d13
1a18c74
c4ad5f8
8c2cd2f
000f8d5
2b1c0cd
f843f77
f344322
69c425b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,18 +68,16 @@ jobs: | |
LD_LIBRARY_PATH=/project/.nox/.cache/libbezier-release/usr/lib | ||
TARGET_NATIVE_ARCH=OFF | ||
CIBW_TEST_COMMAND: pytest {project}/tests/unit | ||
CIBW_TEST_REQUIRES: pytest | ||
CIBW_TEST_REQUIRES: "pytest scipy sympy" | ||
CIBW_SKIP: "*musllinux*" | ||
|
||
- uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3 | ||
with: | ||
name: ${{ matrix.artifact-name }} | ||
path: ./wheelhouse/*.whl | ||
|
||
macos-intel: | ||
# NOTE: For now `scripts/macos/build-wheels-arm.sh` must be used for | ||
# the ARM (M1) wheels. | ||
runs-on: macos-13 | ||
macos-arm64: | ||
runs-on: macos-14 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd consider making a build matrix for this to consolidate |
||
|
||
steps: | ||
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 | ||
|
@@ -102,21 +100,72 @@ jobs: | |
nox --session libbezier-release | ||
|
||
- name: Build wheels | ||
uses: pypa/cibuildwheel@932529cab190fafca8c735a551657247fa8f8eaf #v2.19.1 | ||
uses: pypa/cibuildwheel@932529cab190fafca8c735a551657247fa8f8eaf # v2.19.1 | ||
env: | ||
BEZIER_INSTALL_PREFIX: ./.nox/.cache/libbezier-release/usr | ||
CIBW_ARCHS: arm64 | ||
CIBW_BEFORE_BUILD: | | ||
python -m pip install numpy | ||
CIBW_BUILD: >- | ||
cp310-* | ||
cp311-* | ||
cp312-* | ||
CIBW_ENVIRONMENT: >- | ||
MACOSX_DEPLOYMENT_TARGET=14.0 | ||
Comment on lines
+113
to
+114
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is really unfortunate but Homebrew installs binaries that target the current OS (which is 14.0) This results in
|
||
CIBW_TEST_COMMAND: pytest {project}/tests/unit | ||
CIBW_TEST_REQUIRES: pytest | ||
CIBW_TEST_REQUIRES: "pytest scipy sympy" | ||
|
||
- uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3 | ||
with: | ||
name: macos-intel | ||
name: macos-arm64 | ||
path: ./wheelhouse/*.whl | ||
|
||
macos-x86-64: | ||
runs-on: macos-14 | ||
|
||
steps: | ||
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 | ||
|
||
- uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0 | ||
with: | ||
python-version: "3.12" | ||
|
||
- name: Install `homebrew` in x86_64 arch | ||
run: | | ||
arch -x86_64 /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)" | ||
|
||
- name: Install `gcc` in x86_64 `homebrew | ||
run: | | ||
arch -x86_64 /usr/local/bin/brew install gcc | ||
Comment on lines
+133
to
+139
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
- name: Build `libbezier` | ||
env: | ||
TARGET_NATIVE_ARCH: "OFF" | ||
# NOTE: Could also use $(brew --prefix gcc)/bin/gfortran | ||
CMAKE_FORTRAN_COMPILER: /usr/local/bin/gfortran | ||
Comment on lines
+144
to
+145
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Emphasis! |
||
run: | | ||
python3.12 -m pip install cmake nox | ||
nox --session libbezier-release | ||
|
||
- name: Build wheels | ||
uses: pypa/cibuildwheel@932529cab190fafca8c735a551657247fa8f8eaf # v2.19.1 | ||
env: | ||
BEZIER_INSTALL_PREFIX: ./.nox/.cache/libbezier-release/usr | ||
CIBW_ARCHS: x86_64 | ||
CIBW_BEFORE_BUILD: | | ||
python -m pip install numpy | ||
CIBW_BUILD: >- | ||
cp310-* | ||
cp311-* | ||
cp312-* | ||
CIBW_ENVIRONMENT: >- | ||
MACOSX_DEPLOYMENT_TARGET=14.0 | ||
CIBW_TEST_COMMAND: pytest {project}/tests/unit | ||
CIBW_TEST_REQUIRES: "pytest scipy sympy" | ||
|
||
- uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3 | ||
with: | ||
name: macos-x86-64 | ||
path: ./wheelhouse/*.whl | ||
|
||
sdist: | ||
|
@@ -129,11 +178,15 @@ jobs: | |
with: | ||
python-version: "3.12" | ||
|
||
- name: Install build dependencies | ||
run: | | ||
python3.12 -m pip install build | ||
|
||
- name: Generate sdist (source distribution) | ||
env: | ||
BEZIER_NO_EXTENSION: "True" | ||
run: | | ||
python3.12 setup.py sdist | ||
python3.12 -m build --sdist . | ||
|
||
- uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3 | ||
with: | ||
|
@@ -167,7 +220,7 @@ jobs: | |
"C:\ProgramData\chocolatey\lib\mingw\tools\install\mingw64\bin" >> $env:GITHUB_PATH | ||
|
||
- name: Build wheels | ||
uses: pypa/cibuildwheel@932529cab190fafca8c735a551657247fa8f8eaf #v2.19.1 | ||
uses: pypa/cibuildwheel@932529cab190fafca8c735a551657247fa8f8eaf # v2.19.1 | ||
env: | ||
BEZIER_INSTALL_PREFIX: .\.nox\.cache\libbezier-release\usr | ||
CIBW_ARCHS: AMD64 | ||
|
@@ -183,7 +236,7 @@ jobs: | |
--add-path .\.nox\.cache\libbezier-release\usr\bin | ||
{wheel} | ||
CIBW_TEST_COMMAND: pytest {project}/tests/unit | ||
CIBW_TEST_REQUIRES: pytest | ||
CIBW_TEST_REQUIRES: "pytest scipy sympy" | ||
|
||
- uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3 | ||
with: | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://github.com/dhermes/bezier/pull/318/files#r1643786071 for earlier context on this (this is meant to be temporary!)