Updated: Deprecated isValid

dhershman1 · Oct 15, 2024 · c452de5 · c452de5
1 parent 8609a47
commit c452de5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/src/isValid.js b/src/isValid.js
@@ -1,16 +1,6 @@
 import breakdown from './breakdown.js'
 import uglify from './uglify.js'
 
-/**
- * @private
- * @function
- * @param {String} x The value to check if it is empty
- * @returns {Boolean} Whether or not the value is empty
- */
-function isEmpty (x) {
-  return x === ''
-}
-
 /**
  * @private
  * @function
@@ -39,6 +29,7 @@ function longNumberTest (phone) {
 
 /**
  * @name isValid
+ * @deprecated Use isValidWithFormat instead
  * @since v0.1.0
  * @function
  * @category Function
@@ -56,7 +47,7 @@ export default function isValid (phone) {
   const uglyPhone = uglify(phone)
   const len = uglyPhone.length
 
-  if (isEmpty(uglyPhone) || len < 7) {
+  if (len < 7) {
     return false
   }
 

diff --git a/types/index.d.cts b/types/index.d.cts
@@ -34,6 +34,7 @@ declare namespace phoneFns {
 
     /**
      * Validates the base number, does not take the country code or extension into consideration for this validation
+     * @deprecated Use isValidWithFormat instead
      */
     isValid(phone: string): boolean
 

diff --git a/types/index.d.ts b/types/index.d.ts
@@ -38,6 +38,7 @@ declare namespace phoneFns {
 
     /**
      * Validates the base number, does not take the country code or extension into consideration for this validation
+     * @deprecated Use isValidWithFormat instead
      */
     isValid(phone: string): boolean
-Original file line number
+Diff line change
@@ Expand Up / @@ -34,6 +34,7 @@ declare namespace phoneFns { @@
         /**
          * Validates the base number, does not take the country code or extension into consideration for this validation
+         * @deprecated Use isValidWithFormat instead
          */
         isValid(phone: string): boolean
@@ Expand Down @@