-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.1.0 #17
Merged
Merged
v4.1.0 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Description
🦑 Type of Change
📋 PR Checklist
📝 Changes
💅 New
normalize
functionnormalize('555.444.3333 x 123') // => '5554443333x123'
vsuglify('555.444.3333 x 123') // => 5554443333123
validate
function333-444-5555
comes back valid but444-5555
is invalid to this functionisValidWithFormat
functionvalidate
function for an extra step of validationfindSeparators
functionbreakdownWithFormat
functionbreakdown
but follows a strict format provided by the user to breakdown the number into an object🎊 Enhanced
Phone-fns
is no longer dependant onKyanite
and is dependency free!isValid
description to explain that it mostly focused on NANP numbersbreakdown
description to better explain that it's main focus is NANP numbers and its gachasChore
*.spec.js
instead of just*.js