Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.1.1 Development #18

Merged
merged 11 commits into from
Oct 15, 2024
Merged

v4.1.1 Development #18

merged 11 commits into from
Oct 15, 2024

Conversation

dhershman1
Copy link
Owner

@dhershman1 dhershman1 commented Oct 14, 2024

📄 Description

Re adding code coverage reporting, and fixed some round about logic

🦑 Type of Change

  • Bug Fix
  • Chore
  • New Feature
  • Breaking Change

📋 PR Checklist

  • This pull request has a descriptive title and information useful to a reviewer.
  • All tests are passing
  • Changelog Updated Properly
  • Types updated/added as needed
  • Has new/updated tests

📝 Changes

💄 New

  • Deprecated isValid function in favor of isValidWithFormat

🎊 Enhanced

  • Reset codecov coverage report using c8 package
  • Updated unit tests for some more coverage
  • Cleaned up some round about logic in the codebase

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.49%. Comparing base (d7300c5) to head (a1916cb).
Report is 62 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   96.55%   99.49%   +2.94%     
==========================================
  Files           5       10       +5     
  Lines          29      394     +365     
==========================================
+ Hits           28      392     +364     
- Misses          1        2       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/format.js 97.10% <100.00%> (-2.90%) ⬇️
src/isValid.js 100.00% <100.00%> (ø)
src/isValidWithFormat.js 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@dhershman1 dhershman1 merged commit 8ddf713 into master Oct 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant