Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Adapter methods resolver #214

Conversation

dhilt
Copy link
Owner

@dhilt dhilt commented Sep 26, 2020

This patch is a part of issue #213.
Running Adapter.clip (and other Adapter methods) before the Scroller is initialized did not resolve the returning Promise immediately, and the following code did fail:

this.datasource = new Datasource(...);
this.datasource.adapter.clip().then(() => {
  // never happened before this patch
  console.log('It needs to be resolved immediately');
});

This PR fixes it.

@dhilt dhilt merged commit 993a5ca into master Sep 26, 2020
@dhilt dhilt deleted the issue-213-resolve-adapter-methods-immediately-if-scroller-is-not-initialized branch October 5, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant