Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated party seat shares in Lok Sabha dataset #2

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Integrated party seat shares in Lok Sabha dataset #2

merged 3 commits into from
Mar 7, 2024

Conversation

vaeyias
Copy link
Contributor

@vaeyias vaeyias commented Mar 6, 2024

Changes made:

  • Created a model to retrieve seat shares of each party in each election year
  • Added raw dataset of BJP and INC seat shares in Lok Sahbha from 1962-2019

Adjustments to be made:

  • Update raw dataset to include a few more relevant parties and only include data from the past 20 years

@JusticeV452 JusticeV452 self-requested a review March 6, 2024 19:49
JusticeV452
JusticeV452 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@JusticeV452 JusticeV452 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I made some minor comments to draw attention to areas we should remember to change if new models or commands are added, although I'll update them and merge this branch into main.

backend/app/models.py


class SeatShare(models.Model):
# https://docs.djangoproject.com/en/5.0/ref/models/fields/#enumeration-types
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed

backend/app/management/commands/load_seatshare.py

class Command(BaseCommand):
"""
Custom django-admin command used to run an analysis from the app/analysis folder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be replaced with the actual function of the command

backend/app/management/commands/load_seatshare.py
@@ -0,0 +1,42 @@
"""
Django management command load_dataset
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to load_seatshare

@JusticeV452 JusticeV452 merged commit 33b66ab into main Mar 7, 2024
4 checks passed
@JusticeV452 JusticeV452 deleted the seatshares branch March 7, 2024 18:37
@JusticeV452 JusticeV452 mentioned this pull request Mar 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JusticeV452 JusticeV452 JusticeV452 approved these changes

Assignees

@eleanorxyli eleanorxyli

@vaeyias vaeyias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaeyias @JusticeV452 @eleanorxyli