Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

add ui system to be configured for project #43

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

lukehollis
Copy link

@lukehollis lukehollis commented Feb 7, 2020

Added a homepage for design system as was assigned -- available at /system route

  • frontend/src/UILibrary/scss/_variables.scss should be configured as necessary for the project; similarly _typography.scss, _breakpoints.scss, and other mixins.

Currently appears as this:
screencapture-localhost-8000-system-2020-02-07-17_07_59

@lukehollis lukehollis requested a review from ryaanahmed February 7, 2020 22:11
@mscuthbert
Copy link
Member

The many foreign languages might be intimidating to students -- are there ways to make it more approachable?

Copy link
Member

@ryaanahmed ryaanahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Let's have a discussion offline about how to move forward -- I think the general shape is good, but this introduces some stuff that I think we can probably cut for this project, since we won't need it.

I'm also concerned about things like UILibrary/scss/_reset.scss and UILibrary/scss/mixins/_breakpoints.scss being redundant with Bootstrap, which already has a similar reset and its own grid system.

(More via Slack / chat.)

@lukehollis
Copy link
Author

@ryaanahmed @mscuthbert sounds great! Made the requested changes to the design system for your review!

@lukehollis
Copy link
Author

Hey @ryaanahmed just getting caught up before our staff meeting--is this still useful to consider? Will look at the js lint error.

@ryaanahmed
Copy link
Member

@lukehollis let's pause on this for now -- will connect with you about some of the issues here offline

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants