Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

Choose your own adventure MVP/React skeleton #63

Merged
merged 38 commits into from
Mar 3, 2020
Merged

Conversation

maoivy
Copy link
Contributor

@maoivy maoivy commented Feb 28, 2020

Implemented basic choices and choice tracking in the React skeleton (see #56 for the React skeleton, #45 for the meta issue). Most direct next steps would be integrating with backend to get the adventure JSON objects

maoivy and others added 30 commits February 18, 2020 16:25
Added a desc tab and a place holder description
The options now appear on the screen, along with the text for the current stage. Needs to be styled and for options to actually lead somewhere else.
Copy link
Member

@ryaanahmed ryaanahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good -- this is the perfect level of polish for a mvp since it really lets us feel through whether the thing works or not.

The main thing that doesn't work to me is the success score -- that it's a number that gets summed up as you go. Doesn't feel very intuitive. I think if we did this as a probability, the end result would feel a lot better ("You have a 33% chance of success" vs. "Your success score is 220" [out of what, even?])

I also do think we need the extra string @Dylan-Weber was proposing in the end view, which explains why any given step is likely to succeed or not (e.g., "Choosing Facebook had only 2% chance of success bc almost no one uses it here." etc.)

If you could add these details, then I think we'll be in a good position to add some real stories/data and then polish.

backend/config/urls.py Outdated Show resolved Hide resolved
frontend/src/chooseAdventure/chooseAdventure.js Outdated Show resolved Hide resolved
Get started
</button>
</div>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know this is just mvp / prototyping code but whoa there unnecessary whitespace

setStage: PropTypes.func,
};

/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work with this wrapper component!

@mscuthbert
Copy link
Member

(note also the conflicting stylesheet that needs to be fixed before merge)

@ryaanahmed
Copy link
Member

@Dylan-Weber @maoivy @Mayowa99 -- if someone could turnaround the smaller changes listed here sooner-rather-than-later, then we can merge, deploy, and have @evanlieb give it a spin before our Friday sessions. That'll put is in a strong position to make changes moving into the final version.

@maoivy
Copy link
Contributor Author

maoivy commented Mar 3, 2020

@ryaanahmed could you take a look to see if I've addressed everything correctly?

Changes in the latest commit:

  • changes the view to edX view
  • adds a successDetail property to each option that goes into further detail about how choosing that option might affect your chance of success
    • e.g., if you choose Facebook but Facebook is banned in the country, it says so.
    • should this be displayed as you go along, or only at the end?
  • changed success calculation to be a multiplier: player starts out with 1
    • e.g., if a (general) media campaign has a 90% chance of working and then choosing Twitter has a 60% chance of working, the player ends with a 54% (or 0.54) chance of succeeding
    • should probably refine the calculation

@ryaanahmed
Copy link
Member

@maoivy -- yes! This is fantastic. Just gave it a whirl, and I can already feel how this will be a useful teaching tool.

should this be displayed as you go along, or only at the end?
I think only at the end fits Evan's idea that the player first does things based on their own assumptions and has the underlying issues revealed at the end.

Copy link
Member

@ryaanahmed ryaanahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some technical bits and bobs that need refining here, but this is now a really great prototype. Will merge/deploy and we can show to @evanlieb for feedback.

@ryaanahmed ryaanahmed merged commit e3c0d11 into master Mar 3, 2020
@ryaanahmed ryaanahmed deleted the cyoa-skeleton branch March 3, 2020 21:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants