-
Notifications
You must be signed in to change notification settings - Fork 2
Choose your own adventure MVP/React skeleton #63
Conversation
…rica into cyoa-skeleton
Added a desc tab and a place holder description
…rica into cyoa-skeleton
The options now appear on the screen, along with the text for the current stage. Needs to be styled and for options to actually lead somewhere else.
…rica into cyoa-skeleton
…rica into cyoa-skeleton
…rica into cyoa-skeleton
…rica into cyoa-skeleton
…rica into cyoa-skeleton
Changed formating
…rica into cyoa-skeleton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good -- this is the perfect level of polish for a mvp since it really lets us feel through whether the thing works or not.
The main thing that doesn't work to me is the success score -- that it's a number that gets summed up as you go. Doesn't feel very intuitive. I think if we did this as a probability, the end result would feel a lot better ("You have a 33% chance of success" vs. "Your success score is 220" [out of what, even?])
I also do think we need the extra string @Dylan-Weber was proposing in the end view, which explains why any given step is likely to succeed or not (e.g., "Choosing Facebook had only 2% chance of success bc almost no one uses it here." etc.)
If you could add these details, then I think we'll be in a good position to add some real stories/data and then polish.
Get started | ||
</button> | ||
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know this is just mvp / prototyping code but whoa there unnecessary whitespace
setStage: PropTypes.func, | ||
}; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work with this wrapper component!
(note also the conflicting stylesheet that needs to be fixed before merge) |
@Dylan-Weber @maoivy @Mayowa99 -- if someone could turnaround the smaller changes listed here sooner-rather-than-later, then we can merge, deploy, and have @evanlieb give it a spin before our Friday sessions. That'll put is in a strong position to make changes moving into the final version. |
@ryaanahmed could you take a look to see if I've addressed everything correctly? Changes in the latest commit:
|
@maoivy -- yes! This is fantastic. Just gave it a whirl, and I can already feel how this will be a useful teaching tool.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some technical bits and bobs that need refining here, but this is now a really great prototype. Will merge/deploy and we can show to @evanlieb for feedback.
Implemented basic choices and choice tracking in the React skeleton (see #56 for the React skeleton, #45 for the meta issue). Most direct next steps would be integrating with backend to get the adventure JSON objects