New PicParamSetId to perform proper bounds check #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholroyd
force-pushed
the
pic-param-set-id-bounds-check
branch
2 times, most recently
from
ebe2468 to
10fd58b
Compare
Using a single ParamSetId had the problem that Ids for pic_parameter_set and seq_parameter_set have different maximum allowed values. This change removes that original type and replaces it with seperate PicParamSetId and SeqParamSetId types. SeqParamSetId enforces a limit of 31 as before, but PicParamSetId enforces a limit of 255. Fixes #56
dholroyd
force-pushed
the
pic-param-set-id-bounds-check
branch
from
10fd58b to
6fa1be5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a single ParamSetId had the problem that Ids for pic_parameter_set and seq_parameter_set have different maximum allowed values. This change removes that original type and replaces it with seperate PicParamSetId and SeqParamSetId types.
SeqParamSetId enforces a limit of 31 as before, but PicParamSetId enforces a limit of 255.
Fixes #56