Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse scaling lists properly. #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jerzywilczek
Copy link
Contributor

Scaling lists were skipped previously, I implemented proper parsing, which was mostly coming up with the types to store them in.

I hope the API with const-sized arrays is ok, it seemed whoever implemented skipping the lists wanted to use Vecs initially. I found the generic const more appealing, but can change back to Vecs if needed.

Copy link

github-actions bot commented Nov 13, 2024

🐰 Bencher Report

Branch90/merge
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkEstimated Cyclesestimated cyclesInstructionsinstructionsL1 HitshitsL2 HitshitsRAM HitshitsTotal read+writereads/writes
ci_bench::ci::reader read:setup_video("big_buck_bunny_1080p_24f...📈 view plot
⚠️ NO THRESHOLD
16,755,068.00📈 view plot
⚠️ NO THRESHOLD
8,286,933.00📈 view plot
⚠️ NO THRESHOLD
10,881,698.00📈 view plot
⚠️ NO THRESHOLD
15,565.00📈 view plot
⚠️ NO THRESHOLD
165,587.00📈 view plot
⚠️ NO THRESHOLD
11,062,850.00
🐰 View full continuous benchmarking report in Bencher

@jerzywilczek
Copy link
Contributor Author

jerzywilczek commented Dec 10, 2024

@dholroyd I really don't want to be annoying, but any chance of looking at this at some point? It's ok if the answer is no, I'd just like to know if it makes sense to wait for this. Once again, I really don't want to be annoying or bother you, sorry.

@jerzywilczek jerzywilczek force-pushed the scaling-lists-optional branch from ccfc26e to 54d98a7 Compare December 12, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant