Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for no-std build (extracts std feature, on by default) #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinclark
Copy link

@kevinclark kevinclark commented Aug 19, 2024

The only things keeping rtp-rs from building on no-std are RtpPacketBuilder::build (build_into is fine), the two Error trait impls, some references to std that could be core, and some use of format! in error messages. After Rust 1.18 the errors can be no-std as well since std::error::Error is moving to core. But in the meantime I've got this branch that makes this usable, so I figured I'd share it and see if you're interested in supporting that usecase.

Tests, including doc tests, all still work, though I've moved them to use build_into except for a doc test that shows build still does it's thing. They both delegate the real work to build_into_unchecked so it seemed reasonable to me, but let me know if you feel differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant