Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made obsidian a home page #23

Merged
merged 4 commits into from Feb 4, 2022
Merged

made obsidian a home page #23

merged 4 commits into from Feb 4, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 31, 2022

Made the homepage for the bot.

dhzdhd
dhzdhd requested changes Jan 31, 2022
View reviewed changes
Copy link
Owner

@dhzdhd dhzdhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome and thank you for your first PR to Obsidian.

The landing page is well done but needs a few changes as listed.

The gradient buttons also seem a bit weird considering the overall green theme of the website which we can discuss about.

docs/index.html Outdated Show resolved Hide resolved
docs/index.html Outdated Show resolved Hide resolved
docs/index.html Outdated Show resolved Hide resolved
docs/index.html Outdated Show resolved Hide resolved
docs/index.html Show resolved Hide resolved
docs/index.html Outdated Show resolved Hide resolved
docs/index.html Outdated Show resolved Hide resolved
@dhzdhd dhzdhd linked an issue Jan 31, 2022 that may be closed by this pull request
Github pages #13
Open
@dhzdhd dhzdhd removed a link to an issue Jan 31, 2022
Github pages #13
Open
@dhzdhd
Copy link
Owner

dhzdhd commented Jan 31, 2022

Made the homepage for the bot.

Also, in the future, please create a new branch on your fork before developing a new feature

@dhzdhd dhzdhd added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 1, 2022
@dhzdhd dhzdhd assigned ghost Feb 1, 2022
dhzdhd
dhzdhd requested changes Feb 4, 2022
View reviewed changes
docs/index.html Outdated Show resolved Hide resolved
docs/index.html Show resolved Hide resolved
dhzdhd
dhzdhd requested changes Feb 4, 2022
View reviewed changes
docs/index.html Outdated Show resolved Hide resolved
@dhzdhd dhzdhd merged commit c2f4063 into dhzdhd:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dhzdhd