[OPTIONAL] Add a note about OSX locales and pipenv #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if we should be adding external library-specific notes here since there's most likely a long list of gotchas with those libraries that can be found on their respective repos. @jakedialpad any thoughts? |
Agree. However, this particular issue seemed more platform specific than library specific. Either way, it's not a make or break change. Fine by me either way. |
tinvaan
changed the title
jakedialpad
approved these changes
Mar 1, 2022
| @@ -87,6 +87,13 @@ pipenv install --dev | |||
|
|
|||
| That was easy :) | |||
|
|
|||
| <b>NOTE</b>: If you're on OSX, you may need to set the LOCALE's explcitly before running the `pipenv install` command. | |||
There was a problem hiding this comment.
Just noticed a little typo: explcitly -> explicitly
:p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small note for first time users to follow along.