Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

838 create tabular tab to dashboard and redesign loaded data results #819 #844

Merged
merged 98 commits into from
Sep 18, 2024
Merged

838 create tabular tab to dashboard and redesign loaded data results #819 #844

merged 98 commits into from
Sep 18, 2024

Conversation

laurasootes
Copy link
Contributor

@laurasootes laurasootes commented Aug 22, 2024 •
edited
Loading

This PR adds a tabular page to the dashboard (#838 ) and finalises all dashboard redesigns (#819 ).

Tabular page:
Page is implemented similar to the other pages (text, images, time series).

  • Other than the other pages, the tabular page requires the user to upload the training data, which has to be provided as npy file.
  • For this page it is not obligatory to upload a label text file, because you can also use it for regression models, in which case labels are not necessary. If labels are not uploaded, the page will treat the example as a regression model.
  • The available methods are currently RISE and LIME.
  • For the usage, a user uploads their tabular data csv file (full file). The data is read as pandas dataframe and the full table is shown in the dashboard. The user then clicks on a row in the table, which is the data for which the prediction and explanation is done.
  • A simple test to check the basic functionality of the page is added to the dashboard tests.
  • Note that a tabular example will be added in Add tabular example in dashboard #789

Dashboard redesign changes:

  • _get_method_params is converted into get_params, such that method parameter seleciton is per method
  • For all pages a streamlit container (basically a box) is created at the top which includes the predicted class, number of top classes to show, method selection and method parameters. The different components are only shown when relevant.
  • function _get_top_indices_and_labels is adjusted such that for a regression model the predicted value is printed in the dashboard instead of the predicted class

Other changes:

  • naming of keys for streamlit elements is done in a prettier way

fixes #838 and fixes #819 and fixes #523

@laurasootes
move method, params, prediction, and top to show to container
12a0ab7
@laurasootes
fix text
2e444e4
@laurasootes
set message before tickboxes
3ce30b6
@laurasootes
specify that the row label represents a class
125d0a8
@laurasootes
switch rise and lime for consistency with other pages
911965e
@laurasootes
move method_params into method checkboxes function
2957be9
@laurasootes
move method params into method checkboxes to get the params expander …
bf164bb 
…per method
@laurasootes
delete method header since they are per method now
acc1a32
@laurasootes
make method axis label equal size as class axis label
ac85823
@laurasootes
move prediction to top ourside of container
4d8ef36
@laurasootes
center titles
6f89ba3
@laurasootes
add some space
1918b3a
@laurasootes
update text label
4c62ab3
@laurasootes
make the row elements smaller
eb9af6d
@laurasootes
add some space
7459ed3
@laurasootes
remove sidebar from home page
8432fe3
@laurasootes
use simple logo add
3b7b5f4
@laurasootes
move predicted class inside container
310da69
@laurasootes
move predicted class inside container and all sidebar logo
ed61dbb
@laurasootes
Merge branch '818-dashboard-modifu-input-data-section-for-multiple-ex…
b3de953 
…amples' of https://github.com/dianna-ai/dianna into 819-dashboard-redesign-loaded-data-results
@laurasootes
use page wide layout instead of small centered
afc3092
@laurasootes
Merge branch '790-add-scientific-use-case-frb-to-dashboard' of https:…
343f905 
…//github.com/dianna-ai/dianna into 819-dashboard-redesign-loaded-data-results
@laurasootes
Merge branch '790-add-scientific-use-case-frb-to-dashboard' of https:…
af5e7a2 
…//github.com/dianna-ai/dianna into 819-dashboard-redesign-loaded-data-results
@laurasootes
fix typo
4a3c451
@laurasootes
fix double checkbox
80603d4
@laurasootes
fix key label
dbdbc67
@laurasootes
fix popping
906b6e9
@laurasootes
use f strings
eb5d3f4
@laurasootes
remove print statement
637dae5
@laurasootes
Merge branch '790-add-scientific-use-case-frb-to-dashboard' of https:…
84a873b 
…//github.com/dianna-ai/dianna into 819-dashboard-redesign-loaded-data-results
@laurasootes laurasootes linked an issue Aug 22, 2024 that may be closed by this pull request
Create tabular tab to dashboard #838
Closed
@elboyran elboyran mentioned this pull request Aug 23, 2024
Merged
elboyran
elboyran approved these changes Sep 18, 2024
View reviewed changes
dianna/methods/lime_tabular.py
@@ -63,6 +63,7 @@ def __init__(
LimeTabularExplainer, kwargs)

# temporary solution for setting num_features and top_labels
# when fixed, also fix in dashboard Tabular.py -> _feature_names
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fixed in the next PR?

Copy link
Contributor Author

@laurasootes laurasootes Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the temporary fix itself was already here, it has been added in december PR 661. I did not try to fix the general problem

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe issue 801 mentions the general issue

@laurasootes laurasootes merged commit 45fd4ff into main Sep 18, 2024
15 of 17 checks passed
@laurasootes laurasootes deleted the 838-create-tabular-tab-to-dashboard branch September 18, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elboyran elboyran elboyran approved these changes

Assignees
No one assigned
Labels
dashboard
Projects
None yet
Milestone
No milestone
2 participants
@laurasootes @elboyran