Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu text revision #3902

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

kphoenix137
Copy link
Collaborator

@kphoenix137 kphoenix137 commented Jan 6, 2022

Reorders and renames items on the Escape Menu, and removes "Restart In Town" with a replacement mechanic.

  • Prevents players from accidentally leaving/quitting the game while either in the dying animation, or already dead.
  • "New Game" renamed to "Exit Game" to be more accurate.
  • Being dead now only allows the player to use the Escape/Menu key/button to Load Game in SP and Restart In Town in MP, as a safety mechanism.

SP:
image

image

MP:
image

image

@AJenbo AJenbo added this to the 1.5.0 milestone Jan 6, 2022
@Trihedraf
Copy link
Collaborator

I think we should still have an exit button without saving.

@kphoenix137
Copy link
Collaborator Author

I think we should still have an exit button without saving.

I will update the original post to show most recent changes

@kphoenix137
Copy link
Collaborator Author

kphoenix137 commented Mar 24, 2024

Rebased and cleaned up. No longer removes the red screen from death this time, and no longer displays lost gold. Fixed a problem where the game tried to load a save even if a save didn't exist. Players can no longer use the escape menu during the death sequence before the death message appears, preventing accidental saving or exiting. Also turns off the game menu if it's open when you die, helping save scummers to not lose all their stuff in multiplayer. Had to mix draw order around a bit to stop the death message from writing over DiabloMsg. IMO, DiabloMsg should not be turned red anyway.

@kphoenix137 kphoenix137 marked this pull request as ready for review February 12, 2025 16:17
@kphoenix137
Copy link
Collaborator Author

kphoenix137 commented Feb 12, 2025

Ready for review. Timedemo issue fixed, and revised original description to be more concise, with accurate screenshots to the final product.

@FitzRoyX
Copy link

  • "New Game" renamed to "Exit Game" to be more accurate.

"Exit" and "Quit" are practically synonyms, this reads even less clear than before to me. If you were going to rename "New Game" to anything, it should be "Other Game" or "Select Game". Though it hardly seems worth disrupting 20 years of muscle memory for a slightly better word.

"Options" was probably between save and load to prevent accidental clicks by spacing them out. I don't think that's worth undoing either.

The change that turns escape into something else while dead isn't terrible, but it is a more elaborate way of solving the problem vs just letting escape do the same thing all the time and graying out new game.

@glebm
Copy link
Collaborator

glebm commented Feb 13, 2025

"Exit Game" is indeed a synonym of "Quit Game". Perhaps "Exit to Main Menu"?

@ChaosMarc
Copy link
Contributor

What a about "Exit Game" and "Exit to Desktop" or "Exit Diablo/Hellfire"?

@kphoenix137
Copy link
Collaborator Author

"Exit Game" is indeed a synonym of "Quit Game". Perhaps "Exit to Main Menu"?

I previously replaced Quit Game with Return to Game, which closes the escape menu, however that was causing the timedemo to fail, and I didn't think it was really that worthwhile to remove the Quit Game option, so now we're back to this. :D

Exit to Main Menu is probably a good one.

@kphoenix137
Copy link
Collaborator Author

Replaced "Exit Game" with "Exit to Main Menu"

@kphoenix137
Copy link
Collaborator Author

kphoenix137 commented Feb 13, 2025

"Options" was probably between save and load to prevent accidental clicks by spacing them out. I don't think that's worth undoing either.

Kind of like "Restart in Town" was sandwiched between "New Game" and "Quit Diablo" to encourage accidental clicks that make the player lose all their items, as a hardcore feature since Multiplayer is supposed to be more difficult than Single Player.

@kphoenix137 kphoenix137 marked this pull request as draft February 13, 2025 17:27
@kphoenix137
Copy link
Collaborator Author

I'll need to address non-M&K control schemes, as well as the fact you can still physically click the menu button to bring up the menu while on the death screen.

@FitzRoyX
Copy link

FitzRoyX commented Feb 13, 2025

Kind of like "Restart in Town" was sandwiched between "New Game" and "Quit Diablo" to encourage accidental clicks that make the player lose all their items, as a hardcore feature since Multiplayer is supposed to be more difficult than Single Player.

Well we all know MP was a rushed feature. The arrangement in MP looks like a simple carryover of SP with "Save" going away and "Restart" taking the place of "Load". Just put Restart where Save used to be then.

"Exit Game" is indeed a synonym of "Quit Game". Perhaps "Exit to Main Menu"?

I actually like that "New Game" takes you back to the charselect screen and not title screen. You're more likely to want to load a different game than change modes or settings, so it is effectively a click saver. You can still retreat back from the char screen if you really want.

@kphoenix137
Copy link
Collaborator Author

kphoenix137 commented Feb 13, 2025

Kind of like "Restart in Town" was sandwiched between "New Game" and "Quit Diablo" to encourage accidental clicks that make the player lose all their items, as a hardcore feature since Multiplayer is supposed to be more difficult than Single Player.

Well we all know MP was a rushed feature. The arrangement in MP looks like a simple carryover of SP with "Save" going away and "Restart" taking the place of "Load". Just put Restart where Save used to be then.

Making a lot of extrapolations here

"Exit Game" is indeed a synonym of "Quit Game". Perhaps "Exit to Main Menu"?

I actually like that "New Game" takes you back to the charselect screen and not title screen. You're more likely to want to load a different game than change modes or settings, so it is effectively a click saver. You can still retreat back from the char screen if you really want.

I didn't change the functionality of "New Game". "Exit to Main Menu" still goes back to character select. Anything prior to seeing Tristram is considered the main menu. I think glebm hit the nail on the head with most accurate description of what this option does. "New Game" doesn't create a new game, so despite your muscle memory, I think this should be accurate for the sake of people who are newer or new to the game.

Source/control.cpp Outdated Show resolved Hide resolved
@FitzRoyX
Copy link

"Exit to Main Menu" still goes back to character select. Anything prior to seeing Tristram is considered the main menu. I think glebm hit the nail on the head with most accurate description of what this option does. "New Game" doesn't create a new game

So the main folder of an application can also be any of its subfolders? Doesnt seem right that nothing is a submenu.

"New" does get used as "different" in English, as in "let me go put on a new shirt". It's not perfect but it's a short word that avoids the exit/quit/leave conflict.

@StephenCWills
Copy link
Member

So the main folder of an application can also be any of its subfolders? Doesnt seem right that nothing is a submenu.

Does it also not seem right to you that nothing is a submanager? What do you think of "the character select screen in the main menus"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants