Fix item description rendering issues #7683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `GetLineStartX` assumed that the text fit into a single line.
Fixes InfoString rendering
Pre-wraps the string at spaces, otherwise `DrawString` would hard wrap in the middle of words.
|
The solution is excellent if it is suitable for similar situations. I noticed that there are quite a lot of descriptions of such items. I sincerely thank all those who responded. Gleb is a special respect |
AJenbo
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7651
The initial issue in the unique item info box was caused by
GetLineStartXreturning a negative value for long strings.Fixing that made the text fit but the renderer wraps text at arbitrary points, so we further use
WordWrapStringto break at word boundaries:The info box issue was caused by
KerningFitSpacingonly taking the first line into account.This PR fixes that by recalculating the kerning fit on each new line:
An alternative fix to would be to add a version of
GetLineWidththat calculates the maximum width across all lines. This would make the kerning the same for all lines.I went with kerning fit per line here but I don't have a strong preference either way.
/cc @Riccila