-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Private IP from automap #7752
base: master
Are you sure you want to change the base?
Conversation
Update automap.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the right solution. Showing the gameid and password is an issue to streamers as well. I would favor a toggle in this case. But that does raise the question of how a player can figure out there randomly generated game id.
Possibly it depends on the ingame settings panel.
We could also add a chat command |
There is also the problem during streaming, someone's ip address will displayed in the join tcp game option because it remembers the most recent IP used. Can we add detection for screen recording software that causes the game to obscure sensitive information? |
It's a good idea, but it should be reasonably obvious to people not in the know. People are already a bit confused about where to see the Game ID |
I don't know that that is an option. But I think it's not to big of a problem to have it on the join screen etc, streamers usually know to setup the game of camera, but showing the info on the map means they will often bring it up during normal gameplay. |
Shouldn't you be using zerotier which gives you a virtual/fake IPv4 on its own server anyway? :P |
We provide options for both ZeroTier and TCP so it doesn't seem reasonable to assert that no one should ever use TCP. However, even on ZeroTier, a streamer probably wouldn't want the game name and password to show up on stream. |
Yeah, that's a problem in diablo 2, it shows the password to your game which means people have to post censor screenshots from battle.net. At the minimum there should probably be an option to hide that |
No description provided.