Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another potentially controversial PR. This is also related to diasurgical/devilution#64 (comment)
As galaxyhaxz said, Split Skull Shield also had this same problem in the PR demo, where they used
IPL_DUR
instead ofIPL_SETDUR
, resulting in 5% increased durability, a very strange number to set, as it has absolutely no effect. Split Skull Shield was instead changed to have 15 durability, which is its base item durability in the PR demo (10), plus 5 (the original value set forIPL_DUR
). This ended up making it a 1 durability nerf in retail, since they did not modify it to be 16 durability + 5 durability for whenever they buffed Buckler durability to 16.Following this line of logic, I think an accurate assessment would be that Fleshstinger was intended to have +6 durability from the Long Bow durability at this time in development, not +6% durability (+6% durability results in a durability increase of 2. Like what??). Given that it's a Long Bow which in PR demo, had a durability of 20, the intent was likely for this bow to have instead 26 durability.