Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Enable automatic detecting and loading all filter/sketch types #1717

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

standage
Copy link
Member

@standage standage commented Jun 1, 2017

See #1716.

So far this PR replaces the ad hoc ht_type defines with an enumerated type, and adds values for the *table types. Now the question is how to distinguish between *graph and *table types in the storage class, which by design is agnostic to this.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make clean diff-cover If it introduces new functionality in
    scripts/ is it tested?
  • make format diff_pylint_report cppcheck doc pydocstyle Is it well
    formatted?
  • Did it change the command-line interface? Only backwards-compatible
    additions are allowed without a major version increment. Changing file
    formats also requires a major version number increment.
  • For substantial changes or changes to the command-line interface, is it
    documented in CHANGELOG.md? See keepachangelog
    for more details.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Do the changes respect streaming IO? (Are they
    tested for streaming IO?)

@codecov-io
Copy link

codecov-io commented Jun 2, 2017

Codecov Report

Merging #1717 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1717   +/-   ##
======================================
  Coverage    0.05%   0.05%           
======================================
  Files          91      91           
  Lines       11483   11483           
  Branches     3056    3056           
======================================
  Hits            6       6           
  Misses      11477   11477
Impacted Files Coverage Δ
src/khmer/_cpy_khmer.cc 0% <ø> (ø) ⬆️
src/oxli/storage.cc 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e768617...eb95593. Read the comment docs.

@standage
Copy link
Member Author

standage commented Jun 2, 2017

It looks like we either need to store a ht_type in the storage object at creation time, or pass the value to storage when load and save are invoked. The latter seems less problematic, but neither option sounds very appealing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants