Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Add "good PR" examples #1848

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[MRG] Add "good PR" examples #1848

wants to merge 5 commits into from

Conversation

standage
Copy link
Member

@standage standage commented Mar 14, 2018

Some small additions to the dev docs for new contributors. Closes #464.

Ready for review! Although our docs build seems to be choking on a sphinx dependency...

  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov-io
Copy link

codecov-io commented Apr 2, 2018

Codecov Report

Merging #1848 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1848   +/-   ##
======================================
  Coverage    0.01%   0.01%           
======================================
  Files          78      78           
  Lines       33208   33208           
  Branches      434     434           
======================================
  Hits            5       5           
  Misses      33203   33203

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55ec12a...3dc1b65. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants