[WIP] Experiment compacting counttables into a nodetable given a max abundance criterion #1874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario: I want to query some big ol' counttables, and my k-mers of interest are those that are abundance <= X. Rather than keeping several of these big counttables in memory at once, I'd like to be able to initialize and update a nodetable (with the same number of buckets) to indicate which k-mers satisfy the given criterion. That way I only have to keep one counttable in memory at a time.
This PR introduces two new methods for nodetables:
compose_init
, andcompose_update
. These methods do bit flipping directly on the byte array.The build is currently failing. I'm guessing there's an issue at the C++ level, and maybe at the Cython level as well. This could really benefit from a preliminary review from @luizirber or @camillescott.
make clean diff-cover
or the CodeCov report that is automaticallygenerated following a successful CI build.)
changes were made?
CHANGELOG.md
? Seekeepachangelog for more details.