Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Experiment compacting counttables into a nodetable given a max abundance criterion #1874

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

standage
Copy link
Member

@standage standage commented Jun 18, 2018

Scenario: I want to query some big ol' counttables, and my k-mers of interest are those that are abundance <= X. Rather than keeping several of these big counttables in memory at once, I'd like to be able to initialize and update a nodetable (with the same number of buckets) to indicate which k-mers satisfy the given criterion. That way I only have to keep one counttable in memory at a time.

This PR introduces two new methods for nodetables: compose_init, and compose_update. These methods do bit flipping directly on the byte array.

The build is currently failing. I'm guessing there's an issue at the C++ level, and maybe at the Cython level as well. This could really benefit from a preliminary review from @luizirber or @camillescott.


  • Is any new functionality in tested? (This can be checked with
    make clean diff-cover or the CodeCov report that is automatically
    generated following a successful CI build.)
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Have any substantial changes been documented in CHANGELOG.md? See
    keepachangelog for more details.

Copy link

@Westfargo0147 Westfargo0147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank

Copy link

@Westfargo0147 Westfargo0147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants