Fix publication issues #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-chaix-didomi
force-pushed
the
fix/publication_issues
branch
from
8526c56 to
bb8dbd8
Compare
felipe-saez
approved these changes
Feb 7, 2025
pmerlet-at-didomi
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publication failed because of 2 different issues:
DidomiInitializeParametersDidomiUserParametersandDidomiMultiUserParametersconstructors.disableDidomiRemoteConfigparameter.This PR is fixing those issues by removing null init and adding analyze rules to ignore deprecation message.
I'm also adding a new step to the build workflow to launch a publication dry run once both android and iOS build are successful.