🐛 Waypoint wait for consumer to be ready #1331

cl0ete · 2025-02-14T08:25:36Z

Getting consumer_info on NATS subscription before starting to pull events to make sure consumer is ready.

This solves an issue where we saw timeouts on NATS subscriptions

Method suggested by Claude/GPT/Copilot

waypoint/tests/services/test_nats_service.py

github-actions · 2025-02-14T10:30:23Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	80	2	98%	121–122
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	63	12	81%	111–112, 125–141, 200–201
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	35	79%	118–160, 201–205, 360–364, 403–408, 441–445, 473–478, 527–528
app/services/issuer
acapy_issuer_v2.py	97	12	88%	63, 97–106, 110, 126–127, 172, 225–226, 252
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	8	56%	17–33
credentials.py	14	2	86%	13, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
save_exchange_record.py	13	1	92%	29
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	34–35
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	86	69	20%	36–70, 92–122, 132–181
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	84	4	95%	49–51, 113
waypoint
main.py	50	1	98%	67
waypoint/services
nats_service.py	118	3	97%	73–75
TOTAL	4966	547	89%

Tests	Skipped	Failures	Errors	Time
895	6 💤	0 ❌	0 🔥	4m 29s ⏱️

github-actions · 2025-02-14T10:30:24Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	80	2	98%	121–122
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	63	19	70%	44–50, 80, 111–112, 125–141, 147–150, 200–201
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	46	72%	118–160, 201–205, 360–364, 403–408, 441–445, 463–478, 484–493, 527–528
app/services/issuer
acapy_issuer_v2.py	97	12	88%	63, 97–106, 110, 126–127, 172, 225–226, 252
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	14	2	86%	13, 18
retry_method.py	36	30	17%	15–36, 68–114
save_exchange_record.py	13	1	92%	29
string.py	15	4	73%	15–16, 20, 24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	21–39
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	86	69	20%	36–70, 92–122, 132–181
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	84	4	95%	49–51, 113
waypoint
main.py	50	1	98%	67
waypoint/services
nats_service.py	118	3	97%	73–75
TOTAL	4966	597	88%

Tests	Skipped	Failures	Errors	Time
895	46 💤	0 ❌	0 🔥	4m 15s ⏱️

ff137 · 2025-02-14T16:52:47Z

waypoint/services/nats_service.py

+                not_ready = True
+                while not_ready:
+                    consumer_info = await subscription.consumer_info()
+                    if isinstance(consumer_info, ConsumerInfo):
+                        bound_logger.trace(
+                            "Consumer is ready {}, {}",
+                            consumer_info.name,
+                            consumer_info.stream_name,
+                        )
+                        not_ready = False


I can't figure out from the nats.py code if this actually ensures the consumer is ready. ConsumerInfo has:

@dataclass class ConsumerInfo(Base): """ ConsumerInfo represents the info about the consumer. """ name: str stream_name: str config: ConsumerConfig # FIXME: Do not handle dates for now. # created: datetime delivered: Optional[SequenceInfo] = None ack_floor: Optional[SequenceInfo] = None num_ack_pending: Optional[int] = None num_redelivered: Optional[int] = None num_waiting: Optional[int] = None num_pending: Optional[int] = None cluster: Optional[ClusterInfo] = None push_bound: Optional[bool] = None

and none of it stands out as something we can check that it's ready. So we just assume if we get this response, it's ready. Only way to confirm that is if it fixes the bug ... so, let me know if it does

One nitpick is that I prefer: ready = False and while not ready, then in loop ready = True.
I think the if isinstance check can be dropped.

Come to think about it, the while loop is probably redundant, because the await can only return ConsumerInfo, or raise exception. So I don't think it'll ever loop.

So, presumably we just wanna get consumer info before proceeding.

github-actions · 2025-02-19T12:28:24Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	80	2	98%	121–122
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	63	12	81%	111–112, 125–141, 200–201
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	35	79%	118–160, 201–205, 360–364, 403–408, 441–445, 473–478, 527–528
app/services/issuer
acapy_issuer_v2.py	97	12	88%	63, 97–106, 110, 126–127, 172, 225–226, 252
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	8	56%	17–33
credentials.py	14	2	86%	13, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
save_exchange_record.py	13	1	92%	29
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	34–35
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	86	69	20%	36–70, 92–122, 132–181
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	84	4	95%	49–51, 113
waypoint
main.py	50	1	98%	67
waypoint/services
nats_service.py	129	16	88%	76–78, 189–212, 219–221
TOTAL	4977	560	89%

Tests	Skipped	Failures	Errors	Time
895	6 💤	0 ❌	0 🔥	5m 14s ⏱️

github-actions · 2025-02-19T12:28:25Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	80	2	98%	121–122
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	63	19	70%	44–50, 80, 111–112, 125–141, 147–150, 200–201
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	46	72%	118–160, 201–205, 360–364, 403–408, 441–445, 463–478, 484–493, 527–528
app/services/issuer
acapy_issuer_v2.py	97	12	88%	63, 97–106, 110, 126–127, 172, 225–226, 252
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	14	2	86%	13, 18
retry_method.py	36	30	17%	15–36, 68–114
save_exchange_record.py	13	1	92%	29
string.py	15	4	73%	15–16, 20, 24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	21–39
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	86	69	20%	36–70, 92–122, 132–181
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	84	4	95%	49–51, 113
waypoint
main.py	50	1	98%	67
waypoint/services
nats_service.py	129	16	88%	76–78, 189–212, 219–221
TOTAL	4977	610	88%

Tests	Skipped	Failures	Errors	Time
895	46 💤	0 ❌	0 🔥	5m 13s ⏱️

github-actions · 2025-02-19T13:07:51Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	80	2	98%	121–122
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	63	12	81%	111–112, 125–141, 200–201
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	35	79%	118–160, 201–205, 360–364, 403–408, 441–445, 473–478, 527–528
app/services/issuer
acapy_issuer_v2.py	97	12	88%	63, 97–106, 110, 126–127, 172, 225–226, 252
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	8	56%	17–33
credentials.py	14	2	86%	13, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
save_exchange_record.py	13	1	92%	29
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	34–35
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	86	69	20%	36–70, 92–122, 132–181
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	84	4	95%	49–51, 113
waypoint
main.py	50	1	98%	67
waypoint/services
nats_service.py	130	16	88%	76–78, 190–213, 220–222
TOTAL	4978	560	89%

Tests	Skipped	Failures	Errors	Time
895	6 💤	20 ❌	67 🔥	4m 13s ⏱️

github-actions · 2025-02-19T13:07:52Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	80	2	98%	121–122
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	63	19	70%	44–50, 80, 111–112, 125–141, 147–150, 200–201
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	46	72%	118–160, 201–205, 360–364, 403–408, 441–445, 463–478, 484–493, 527–528
app/services/issuer
acapy_issuer_v2.py	97	12	88%	63, 97–106, 110, 126–127, 172, 225–226, 252
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	14	2	86%	13, 18
retry_method.py	36	30	17%	15–36, 68–114
save_exchange_record.py	13	1	92%	29
string.py	15	4	73%	15–16, 20, 24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	21–39
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	86	69	20%	36–70, 92–122, 132–181
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	84	4	95%	49–51, 113
waypoint
main.py	50	1	98%	67
waypoint/services
nats_service.py	130	16	88%	76–78, 190–213, 220–222
TOTAL	4978	610	88%

Tests	Skipped	Failures	Errors	Time
895	46 💤	44 ❌	24 🔥	5m 13s ⏱️

github-actions · 2025-02-19T13:18:31Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	80	2	98%	121–122
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	63	12	81%	111–112, 125–141, 200–201
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	35	79%	118–160, 201–205, 360–364, 403–408, 441–445, 473–478, 527–528
app/services/issuer
acapy_issuer_v2.py	97	12	88%	63, 97–106, 110, 126–127, 172, 225–226, 252
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	8	56%	17–33
credentials.py	14	2	86%	13, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
save_exchange_record.py	13	1	92%	29
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	34–35
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	86	69	20%	36–70, 92–122, 132–181
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	84	4	95%	49–51, 113
waypoint
main.py	50	1	98%	67
waypoint/services
nats_service.py	130	16	88%	76–78, 190–213, 220–222
TOTAL	4978	560	89%

Tests	Skipped	Failures	Errors	Time
895	6 💤	0 ❌	0 🔥	4m 21s ⏱️

github-actions · 2025-02-19T13:18:32Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	80	2	98%	121–122
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	63	19	70%	44–50, 80, 111–112, 125–141, 147–150, 200–201
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	46	72%	118–160, 201–205, 360–364, 403–408, 441–445, 463–478, 484–493, 527–528
app/services/issuer
acapy_issuer_v2.py	97	12	88%	63, 97–106, 110, 126–127, 172, 225–226, 252
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	14	2	86%	13, 18
retry_method.py	36	30	17%	15–36, 68–114
save_exchange_record.py	13	1	92%	29
string.py	15	4	73%	15–16, 20, 24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	21–39
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	86	69	20%	36–70, 92–122, 132–181
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	84	4	95%	49–51, 113
waypoint
main.py	50	1	98%	67
waypoint/services
nats_service.py	130	16	88%	76–78, 190–213, 220–222
TOTAL	4978	610	88%

Tests	Skipped	Failures	Errors	Time
895	46 💤	0 ❌	0 🔥	3m 40s ⏱️

github-actions · 2025-02-19T14:20:23Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	80	2	98%	121–122
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	63	12	81%	111–112, 125–141, 200–201
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	35	79%	118–160, 201–205, 360–364, 403–408, 441–445, 473–478, 527–528
app/services/issuer
acapy_issuer_v2.py	97	12	88%	63, 97–106, 110, 126–127, 172, 225–226, 252
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	8	56%	17–33
credentials.py	14	2	86%	13, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
save_exchange_record.py	13	1	92%	29
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	34–35
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	86	69	20%	36–70, 92–122, 132–181
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	84	4	95%	49–51, 113
waypoint
main.py	50	1	98%	67
waypoint/services
nats_service.py	130	16	88%	76–78, 190–213, 220–222
TOTAL	4978	560	89%

Tests	Skipped	Failures	Errors	Time
895	6 💤	0 ❌	0 🔥	4m 49s ⏱️

github-actions · 2025-02-19T14:20:23Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	80	2	98%	121–122
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	63	19	70%	44–50, 80, 111–112, 125–141, 147–150, 200–201
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	46	72%	118–160, 201–205, 360–364, 403–408, 441–445, 463–478, 484–493, 527–528
app/services/issuer
acapy_issuer_v2.py	97	12	88%	63, 97–106, 110, 126–127, 172, 225–226, 252
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	14	2	86%	13, 18
retry_method.py	36	30	17%	15–36, 68–114
save_exchange_record.py	13	1	92%	29
string.py	15	4	73%	15–16, 20, 24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	21–39
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	86	69	20%	36–70, 92–122, 132–181
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	84	4	95%	49–51, 113
waypoint
main.py	50	1	98%	67
waypoint/services
nats_service.py	130	16	88%	76–78, 190–213, 220–222
TOTAL	4978	610	88%

Tests	Skipped	Failures	Errors	Time
895	46 💤	0 ❌	0 🔥	5m 12s ⏱️

waypoint/services/nats_service.py

github-actions · 2025-02-21T12:32:29Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	80	2	98%	121–122
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	63	12	81%	111–112, 125–141, 200–201
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	35	79%	118–160, 201–205, 360–364, 403–408, 441–445, 473–478, 527–528
app/services/issuer
acapy_issuer_v2.py	97	12	88%	63, 97–106, 110, 126–127, 172, 225–226, 252
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	8	56%	17–33
credentials.py	14	2	86%	13, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
save_exchange_record.py	13	1	92%	29
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	34–35
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	86	69	20%	36–70, 92–122, 132–181
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	84	4	95%	49–51, 113
waypoint
main.py	50	1	98%	67
waypoint/services
nats_service.py	128	16	88%	76–78, 186–209, 216–218
TOTAL	4976	560	89%

Tests	Skipped	Failures	Errors	Time
895	6 💤	0 ❌	0 🔥	4m 44s ⏱️

github-actions · 2025-02-21T12:32:30Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	80	2	98%	121–122
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	63	19	70%	44–50, 80, 111–112, 125–141, 147–150, 200–201
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	46	72%	118–160, 201–205, 360–364, 403–408, 441–445, 463–478, 484–493, 527–528
app/services/issuer
acapy_issuer_v2.py	97	12	88%	63, 97–106, 110, 126–127, 172, 225–226, 252
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	14	2	86%	13, 18
retry_method.py	36	30	17%	15–36, 68–114
save_exchange_record.py	13	1	92%	29
string.py	15	4	73%	15–16, 20, 24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	21–39
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	86	69	20%	36–70, 92–122, 132–181
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	84	4	95%	49–51, 113
waypoint
main.py	50	1	98%	67
waypoint/services
nats_service.py	128	16	88%	76–78, 186–209, 216–218
TOTAL	4976	610	88%

Tests	Skipped	Failures	Errors	Time
895	46 💤	0 ❌	0 🔥	4m 59s ⏱️

sonarqubecloud · 2025-02-24T05:48:37Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

waypoint/services/nats_service.py

@@ -93,6 +96,11 @@
                subscription = await self.js_context.pull_subscribe(
                    config=config, **subscribe_kwargs
                )
+
+                # Get consumer info to verify that the subscription was successful
+                # TODO test if this is necessary/helps


cl0ete self-assigned this Feb 14, 2025

github-advanced-security bot found potential problems Feb 14, 2025

View reviewed changes

waypoint/tests/services/test_nats_service.py Fixed Show fixed Hide fixed

cl0ete changed the title ~~⚗️ Waypoint wait for consumer to be ready~~ 🐛 Waypoint wait for consumer to be ready Feb 14, 2025

github-advanced-security bot found potential problems Feb 14, 2025

View reviewed changes

waypoint/tests/services/test_nats_service.py Fixed Show fixed Hide fixed

cl0ete added bug Something isn't working improvement improving on something that is already existing (not a new feature as such) labels Feb 14, 2025

cl0ete added 16 commits February 14, 2025 12:18

wait for consumer to be ready

6245dfd

🎨

66d5b12

disable unit test while testing

5dc579e

add trace log

636a199

🎨

a41d69e

make readable

bb5aa33

re-add tests

613389c

update test

ef0c2c9

update tests

e41f166

update test

eedc7a8

🎨

12563f1

# pylint: disable=redefined-outer-name

712dcc5

🎨

c9827c6

🎨

4170623

rename

a199fc1

🎨

3da632f

cl0ete force-pushed the waypoint-consumer-ready branch from f56100e to 3da632f Compare February 14, 2025 10:18

cl0ete marked this pull request as ready for review February 14, 2025 10:18

cl0ete requested a review from ff137 February 14, 2025 10:18

cl0ete temporarily deployed to dev February 14, 2025 10:20 — with GitHub Actions Inactive

ff137 reviewed Feb 14, 2025

View reviewed changes

Remove heartbeat from fetch

7ad3f73

wdbasson had a problem deploying to dev February 19, 2025 12:57 — with GitHub Actions Failure

wdbasson force-pushed the waypoint-consumer-ready branch from c12cfc3 to b215320 Compare February 19, 2025 13:00

wdbasson had a problem deploying to dev February 19, 2025 13:01 — with GitHub Actions Error

wdbasson force-pushed the waypoint-consumer-ready branch from b215320 to 1f588ac Compare February 19, 2025 13:06

wdbasson temporarily deployed to dev February 19, 2025 13:07 — with GitHub Actions Inactive

Log TimeoutErrors. Fetch timeout 200ms

ea0a902

wdbasson force-pushed the waypoint-consumer-ready branch from 1f588ac to ea0a902 Compare February 19, 2025 14:09

wdbasson temporarily deployed to dev February 19, 2025 14:10 — with GitHub Actions Inactive

ff137 reviewed Feb 19, 2025

View reviewed changes

waypoint/services/nats_service.py Outdated Show resolved Hide resolved

remove is instance check

0e66862

cl0ete marked this pull request as draft February 21, 2025 12:20

cl0ete temporarily deployed to dev February 21, 2025 12:21 — with GitHub Actions Inactive

github-advanced-security bot found potential problems Feb 21, 2025

View reviewed changes

waypoint/services/nats_service.py Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Feb 21, 2025

View reviewed changes

waypoint/services/nats_service.py Fixed Show fixed Hide fixed

waypoint/services/nats_service.py Fixed Show fixed Hide fixed

heartbeat 0.05

977c379

cl0ete added 2 commits February 21, 2025 15:03

remove import

5995555

update comment

b984a1e

github-advanced-security bot found potential problems Feb 24, 2025

View reviewed changes

Update nats_service.py

62bd628

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Waypoint wait for consumer to be ready #1331

🐛 Waypoint wait for consumer to be ready #1331

cl0ete commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025

github-actions bot commented Feb 14, 2025

ff137 Feb 14, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 21, 2025

github-actions bot commented Feb 21, 2025

sonarqubecloud bot commented Feb 24, 2025

🐛 Waypoint wait for consumer to be ready #1331

Are you sure you want to change the base?

🐛 Waypoint wait for consumer to be ready #1331

Conversation

cl0ete commented Feb 14, 2025 • edited Loading

github-actions bot commented Feb 14, 2025

github-actions bot commented Feb 14, 2025

ff137 Feb 14, 2025

Choose a reason for hiding this comment

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 21, 2025

github-actions bot commented Feb 21, 2025

sonarqubecloud bot commented Feb 24, 2025

Quality Gate passed

cl0ete commented Feb 14, 2025 •

edited

Loading