Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart and CD Workflow #43

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Helm Chart and CD Workflow #43

merged 2 commits into from
Jul 27, 2023

Conversation

rblaine95
Copy link
Collaborator

@rblaine95 rblaine95 commented Jul 25, 2023

  • Initial Helm and Continuous Deploy Workflow
  • Update Prettier --ignore-path
    • Prettier uses .gitignore and .prettierignore by default
    • By specifying --ignore-path .gitignore, .prettierignore appears to
      be ignored, unlike eslint --ignore-path which is in addition to
      .eslintignore
    • Add helm to .eslintignore too

Relates to #1

@rblaine95 rblaine95 added the enhancement New feature or request label Jul 25, 2023
@rblaine95 rblaine95 requested review from jakubkoci and wdbasson July 25, 2023 13:42
@rblaine95 rblaine95 self-assigned this Jul 25, 2023
@rblaine95 rblaine95 temporarily deployed to dev July 25, 2023 13:57 — with GitHub Actions Inactive
@rblaine95 rblaine95 temporarily deployed to dev July 25, 2023 14:00 — with GitHub Actions Inactive
@rblaine95 rblaine95 marked this pull request as ready for review July 25, 2023 14:09
@rblaine95
Copy link
Collaborator Author

rblaine95 commented Jul 25, 2023

@wdbasson @jakubkoci, take a look, let me know what you think, feel free to turn the pedantic dial up to 11.

cargo clippy -- -Dwarnings -Wclippy::pedantic -Wclippy::nursery

@rblaine95 rblaine95 temporarily deployed to dev July 26, 2023 09:14 — with GitHub Actions Inactive
@rblaine95 rblaine95 requested a deployment to dev July 26, 2023 09:17 — with GitHub Actions Abandoned
@rblaine95 rblaine95 temporarily deployed to dev July 26, 2023 09:19 — with GitHub Actions Inactive
@rblaine95 rblaine95 force-pushed the helm-cd branch 3 times, most recently from ee076c9 to 6a72c36 Compare July 26, 2023 11:55
@rblaine95
Copy link
Collaborator Author

@jakubkoci, I noticed the Swagger UI (/api/docs/ui) isn't available when using the deployed endpoint (https://ssi-trust-registry.cloudapi.dev.didxtech.com/api/docs/ui) but it is up if I yarn dev and go to http://localhost:3000/api/docs/ui.

It also doesn't work if I kubectl port-forward 3000 to the pod/service and go to http://localhost:3000...
Is this by design?

Copy link
Collaborator

@jakubkoci jakubkoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly an educational review for me :) It's definitely not my domain. But it seems like a lot of stuff to run one service 🤔

@jakubkoci
Copy link
Collaborator

@rblaine95 Yes, I decided to hide API docs at the start. But we can eventually easily allow.

It also doesn't work if I kubectl port-forward 3000 to the pod/service and go to http://localhost:3000...

I'm not sure if I understand what's the problem there 🤔

@rblaine95
Copy link
Collaborator Author

I'm not sure if I understand what's the problem there 🤔

It's no problem, I was just trying to understand why I couldn't access the Swagger UI (was afraid maybe I broke something).

If you kubectl port-forward you can access a pod/service in K8s via http://localhost:xyz, which makes the pod think it's being accessed from itself.
Usually it's useful for cutting out middlemen (like loadbalancers/ingress controllers/etc to test if anything in the chain is causing issues) and to access endpoints that can only be accessed from the localhost interface, like if you have a /api/admin that you only want localhost to be able to access.

I suspected that the Swagger UI was only accessible from localhost, hence the test, but it also didn't work.

* Prettier uses `.gitignore` and `.prettierignore` by default
* By specifying `--ignore-path .gitignore`, `.prettierignore` appears to
  be ignored, unlike `eslint --ignore-path` which is in addition to
  `.eslintignore`
* Add `helm` to `.eslintignore` too
@rblaine95 rblaine95 merged commit d4d841c into main Jul 27, 2023
@rblaine95 rblaine95 deleted the helm-cd branch July 27, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants