-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm Chart and CD Workflow #43
Conversation
@wdbasson @jakubkoci, take a look, let me know what you think, feel free to turn the pedantic dial up to 11.
|
ee076c9
to
6a72c36
Compare
@jakubkoci, I noticed the Swagger UI ( It also doesn't work if I |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly an educational review for me :) It's definitely not my domain. But it seems like a lot of stuff to run one service 🤔
@rblaine95 Yes, I decided to hide API docs at the start. But we can eventually easily allow.
I'm not sure if I understand what's the problem there 🤔 |
It's no problem, I was just trying to understand why I couldn't access the Swagger UI (was afraid maybe I broke something). If you I suspected that the Swagger UI was only accessible from |
* Prettier uses `.gitignore` and `.prettierignore` by default * By specifying `--ignore-path .gitignore`, `.prettierignore` appears to be ignored, unlike `eslint --ignore-path` which is in addition to `.eslintignore` * Add `helm` to `.eslintignore` too
--ignore-path
.gitignore
and.prettierignore
by default--ignore-path .gitignore
,.prettierignore
appears tobe ignored, unlike
eslint --ignore-path
which is in addition to.eslintignore
helm
to.eslintignore
tooRelates to #1