Add frontend language cookie functionality #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benjamin-K
requested changes
Sep 10, 2024
| { | ||
| $detectedLocale = $this->localeDetector->detectLocaleFromLocaleTag($feLanguageCookie); | ||
|
|
||
| if (!$detectedLocale instanceof Locale) { |
There was a problem hiding this comment.
Could you please move L150-168 to a new function and use it in both findMatchingPresetBy... methods?
Sth. like:
$detectedLocale = 'dependsOnMethod';
$preset = $this->findPresetByLocale($detectedLocale);
// For the presetByLanguageCookie one can directly return $preset.
// This check is only neccessary in the AcceptLanguageHeader while loop.
if ($preset !== null) {
return $preset;
}
// ...
Configuration/Settings.yaml
Outdated
| @@ -2,3 +2,5 @@ Wegmeister: | |||
| LanguageRedirect: | |||
| # Add mappings for language codes if you use some different codes than the default ones. | |||
| languageCodeOverrides: {} | |||
| # configure the name of your frontend language cookie name | |||
| feLanguageCookieName: _fe_language | |||
There was a problem hiding this comment.
Use null as default here, because one has to implement the cookie handling for this to work. This will prevent the backend from trying to read cookies that are missing.
If you want, you can add some more information on this in the readme, but I'm also fine with the current state.
|
Hey I updated the code like you requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our projects we set a frontend language cookie whenever the user changes the language via the language menu.
Like that the user will always get on the language he visited last and doesn't have to switch the language everytime he revisits your website.
We think that this functionality may also be useful for others hence why we create this merge request.
Best Regards
Yannis