fix: restore bookmark functionality #3113
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2700
Other related PRs: #2715
Summary: All page bookmarks incorrectly referenced last page after PDFKit was upgraded and code refactored.
The faulty code refactoring applied the bookmarks at the end of the rendering, when the context is attached to the last page.
The fix is to attach bookmarks as the context changes rather than wait until the rendering is complete (and context lost).
I had suspected the issue was in PDFKit, but you can verify the PDFKit code works as expected by going to
the interactive browser provided in the libraries documentation and paste the following code provided below. The expectation is that clicking on a bookmark will take to that page.