Fix nullable binds in the #[derive(Multiconnection)] implementation
#3716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were previously broken as they wouldn't set the inner bind value at all. We introduce a new `InnerBindValueKind` to handle them correctly. In addition this commit improves the internal panic handling of the multi connection implementation by either changing existing `unwrap()` calls to return an error instead or by using `expect()` to provide an unique error message. This hopefully should make it easier to pin down future issues.
weiznich
added
the
maybe backport
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
weiznich
added a commit
to weiznich/diesel
that referenced
this pull request
Aug 18, 2023
…th_multiconnection Fix nullable binds in the `#[derive(Multiconnection)]` implementation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were previously broken as they wouldn't set the inner bind value at all. We introduce a new
InnerBindValueKindto handle them correctly.In addition this commit improves the internal panic handling of the multi connection implementation by either changing existing
unwrap()calls to return an error instead or by usingexpect()to provide an unique error message. This hopefully should make it easier to pin down future issues.