Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add @peterschrammel as code owner to /src/solvers/floatbv #8580

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

kroening
Copy link
Member

@kroening kroening commented Feb 4, 2025

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • n/a My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening marked this pull request as ready for review February 4, 2025 16:33
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.85%. Comparing base (c66ffbe) to head (ae83943).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8580   +/-   ##
========================================
  Coverage    78.85%   78.85%           
========================================
  Files         1732     1732           
  Lines       199119   199119           
  Branches     18560    18560           
========================================
  Hits        157023   157023           
  Misses       42096    42096           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -62,8 +62,8 @@
/jbmc/src/jdiff/ @peterschrammel
/src/cpp/ @kroening @tautschnig @peterschrammel
/src/solvers/smt2 @kroening @martin-cs @peterschrammel @TGWDB
/src/solvers/smt2_incremental @peterschrammel @thomasspriggs @TGWDB @esteffin
/src/solvers/Makefile @kroening @tautschnig @peterschrammel @TGWDB @esteffin
/src/solvers/smt2_incremental @peterschrammel @thomasspriggs @TGWDB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't expect thomasspriggs is going to contribute anymore.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if Thomas does: given Thomas lacks write access at this point, code ownership wouldn't entail a sufficient approval anymore.

@kroening kroening merged commit 3c4ffae into develop Feb 4, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants