Respect and Use the Value for WLAN_ROOT Consistently and Pervasively #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable 'WLAN_ROOT' is intended to point at the root of the project source tree and the location of Kbuild, which is what the build Linux expects 'M' to be set to. Consequently, Use the value for WLAN_ROOT consistently and pervasively everywhere 'M' is set and passed to the Linux build. In particular, 'PWD' will be incorrect if make is invoked with '-C' and '$(shell pwd)' may be in conflict with a value of 'WLAN_ROOT' asserted in the environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
WLAN_ROOTis intended to point at the root of the project source tree and the location of Kbuild, which is what the build Linux expectsMto be set to.Consequently, use the value for
WLAN_ROOTconsistently and pervasively everywhereMis set and passed to the Linux build.In particular,
PWDwill be incorrect if make is invoked with-Cand$(shell pwd)may be in conflict with a value ofWLAN_ROOTasserted in the environment.