Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

VER-3: removing cypress and deps upgrade. #10

Closed
wants to merge 3 commits into from
Closed

Conversation

n3op2
Copy link
Contributor

@n3op2 n3op2 commented Jun 7, 2023

What

  • removed cypress since it was just a placeholder
  • added overrides for the below reason with react-json-view
  • all dependencies upgraded
  • removed cypress
  • removed tests from build spec

Compatibility Issues

flux dep

npm WARN ERESOLVE overriding peer dependency                                                                                                                                                                                                         
npm WARN While resolving: [email protected]                                                                                                                                                                                                                 
npm WARN Found: [email protected]                                                                                                                                                                                                                         
npm WARN node_modules/react                                                                                                                                                                                                                          
npm WARN   react@"^18.2.0" from the root project                                                                                                                                                                                                     
npm WARN   7 more (react-dom, react-json-view, react-scripts, ...)                                                                                                                                                                                   
npm WARN                                                                                                                                                                                                                                             
npm WARN Could not resolve dependency:                                                                                                                                                                                                               
npm WARN peer react@"^15.0.2 || ^16.0.0 || ^17.0.0" from [email protected]                                                                                                                                                                                  
npm WARN node_modules/flux                                                                                                                                                                                                                           
npm WARN   flux@"^4.0.1" from [email protected]                                                                                                                                                                                                 
npm WARN   node_modules/react-json-view                                                                                                                                                                                                              
npm WARN                                                                                                                                                                                                                                             
npm WARN Conflicting peer dependency: [email protected]                                                                                                                                                                                                   
npm WARN node_modules/react                                                                                                                                                                                                                          
npm WARN   peer react@"^15.0.2 || ^16.0.0 || ^17.0.0" from [email protected]                                                                                                                                                                                
npm WARN   node_modules/flux                                                                                                                                                                                                                         
npm WARN     flux@"^4.0.1" from [email protected]                                                                                                                                                                                               
npm WARN     node_modules/react-json-view                                                                                                                                                                                                            
npm WARN EBADENGINE Unsupported engine {                                                                                                                                                                                                             
npm WARN EBADENGINE   package: '[email protected]',                                                                                                                                                                                          
npm WARN EBADENGINE   required: { node: '16.x.x', npm: '8.x.x' },                                                                                                                                                                                    
npm WARN EBADENGINE   current: { node: 'v18.14.0', npm: '9.6.4' }                                                                                                                                                                                    
npm WARN EBADENGINE }  

react-json-view dep


npm ERR! node_modules/react                                                                                                                                                                                                                  npm ERR!   react@"^18.2.0" from the root project                                                                                                                                                                                                     
npm ERR!                                                                                                                                                                                                                                             
npm ERR! Could not resolve dependency:                                                                                                                                                                                                               
npm ERR! peer react@"^17.0.0 || ^16.3.0 || ^15.5.4" from [email protected]                                                                                                                                                                      
npm ERR! node_modules/react-json-view                                                                                                                                                                                                                
npm ERR!   react-json-view@"^1.21.3" from the root project                                                                                                                                                                                           
npm ERR!                                                                                                                                                                                                                                             
npm ERR! Fix the upstream dependency conflict, or retry                                                                                                                                                                                              
npm ERR! this command with --force or --legacy-peer-deps                                                                                                                                                                                             
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.                                                                                                                                                                                                                                                                        
```

Solutions

@n3op2
Copy link
Contributor Author

n3op2 commented Jun 7, 2023

closing as we will be going with react 17 to avoid dependency hell when using 18, a lot of modules are not ready for react 18.

@n3op2 n3op2 closed this Jun 7, 2023
@n3op2 n3op2 deleted the upgrade/ver-3 branch June 7, 2023 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant