fix: DataType.prototype.getByVersionId could return wrong type
#963
+45
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHahn
force-pushed
the
fix-getByVersionId-returning-from-same-store
branch
from
cb87765 to
b5a797a
Compare
We have many `DataType`s backed by the same `DataStore`. For example,
observations and tracks are both in the "data" store.
`DataType.prototype.getByVersionId` would pull documents from the store
without checking the type, which could cause issues. Simple code
example:
const track = await trackDataType.create({ /* ... */ })
await observationDataType.getByVersionId(track.versionId)
// => the track, unexpectedly!
Now, it throws a `NotFoundError`.
EvanHahn
force-pushed
the
fix-getByVersionId-returning-from-same-store
branch
from
3b35196 to
1c7b7cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have many
DataTypes backed by the sameDataStore. For example, observations and tracks are both in the "data" store.DataType.prototype.getByVersionIdwould pull documents from the store without checking the type, which could cause issues. Simple code example:Now, it throws a
NotFoundError.