Es/unable to cancel invite #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSin
force-pushed
the
es/unable-to-cancel-invite
branch
from
4a80fbe to
8d0119b
Compare
ErikSin
commented
Apr 22, 2024
Comment on lines
+32
to
+40
| setTimeout(() => { | ||
| queryClient | ||
| .invalidateQueries({queryKey: [INVITE_KEY, PROJECTS_KEY]}) | ||
| .then(() => { | ||
| if (projectId) { | ||
| switchActiveProject(projectId); | ||
| } | ||
| }); | ||
| }, 5000); |
There was a problem hiding this comment.
This setTimeout is a workaround.
Race condition is happening where:
- invitee accepts invite
- invitation resolves
- when invitation resolves, the cache of
allprojectsis refetched - user is switched to the new project.
Between steps 2 and 3 there is a race condition, where the project has not been created yet, so the project in unavailable. This was discussed with @EvanHahn
There was a problem hiding this comment.
I could see adding a comment explaining this, but I hope to fix this soon in any case.
EvanHahn
approved these changes
Apr 22, 2024
Comment on lines
+32
to
+40
| setTimeout(() => { | ||
| queryClient | ||
| .invalidateQueries({queryKey: [INVITE_KEY, PROJECTS_KEY]}) | ||
| .then(() => { | ||
| if (projectId) { | ||
| switchActiveProject(projectId); | ||
| } | ||
| }); | ||
| }, 5000); |
There was a problem hiding this comment.
I could see adding a comment explaining this, but I hope to fix this soon in any case.
| return; | ||
| } | ||
| sendInviteMutation.mutate( | ||
| // @ts-ignore |
There was a problem hiding this comment.
Is this error happening because role is invalid? If so, this was fixed in 1a34eb3. You should be able to merge main to pick this up.
| {deviceId, role: {roleId: role}}, | ||
| { | ||
| onSuccess: val => { | ||
| // If user has attempted to cancel and invite, but an invite has been accepted, let user know their cancellation was unsuccessfuly |
There was a problem hiding this comment.
Nitpick:
Suggested change
| // If user has attempted to cancel and invite, but an invite has been accepted, let user know their cancellation was unsuccessfuly | |
| // If user has attempted to cancel and invite, but an invite has been accepted, let user know their cancellation was unsuccessful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen to indicate that cancelling an invite was unsuccessful.
closes #234